Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(surround_obstacle_checker): add unit tests #9039

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Oct 7, 2024

Description

image

Related links

Parent Issue:

  • Link

How was this PR tested?

  • PASS COLCON TEST
  • PASS TIER IV INTERNAL SCENARIOS

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Oct 7, 2024
Copy link

github-actions bot commented Oct 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@satoshi-ota satoshi-ota marked this pull request as ready for review October 7, 2024 01:34
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 29.16667% with 17 lines in your changes missing coverage. Please review.

Project coverage is 26.61%. Comparing base (1e26395) to head (64a4631).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ng/autoware_surround_obstacle_checker/src/node.cpp 29.16% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9039      +/-   ##
==========================================
+ Coverage   26.55%   26.61%   +0.05%     
==========================================
  Files        1296     1297       +1     
  Lines       95711    95713       +2     
  Branches    38983    39099     +116     
==========================================
+ Hits        25419    25474      +55     
+ Misses      67725    67671      -54     
- Partials     2567     2568       +1     
Flag Coverage Δ *Carryforward flag
differential 2.38% <29.16%> (?)
total 26.57% <ø> (+0.01%) ⬆️ Carriedforward from 98fcf17

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link
Contributor

@go-sakayori go-sakayori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshi-ota satoshi-ota merged commit 46f2650 into autowarefoundation:main Oct 7, 2024
35 of 36 checks passed
@satoshi-ota satoshi-ota deleted the test/soc branch October 7, 2024 04:54
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
)

* refactor: isStopRequired

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* test: write test for isStopRequired

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* refactor: use universe utils

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

* fix: shutdown

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>

---------

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants