Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lane_change): refactor get_lane_change_lanes function #9044

Conversation

zulfaqar-azmi-t4
Copy link
Contributor

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 commented Oct 7, 2024

Description

Refactor get_lane_change_lanes function.
Two utilities functions are added;

  1. to_geom_msg_pose which will create pose from lanelet points
  2. is_mandatory_lane_change which list the lane change type for mandatory lane change

Related links

Parent Issue:

  • Link

Compile autoware and run psim

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Copy link

github-actions bot commented Oct 7, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Oct 7, 2024
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

Attention: Patch coverage is 37.03704% with 17 lines in your changes missing coverage. Please review.

Project coverage is 26.52%. Comparing base (4f97001) to head (195dc48).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...oware/behavior_path_planner_common/utils/utils.hpp 0.00% 7 Missing ⚠️
...are_behavior_path_lane_change_module/src/scene.cpp 42.85% 4 Missing ⚠️
...havior_path_lane_change_module/src/utils/utils.cpp 63.63% 3 Missing and 1 partial ⚠️
...e_behavior_path_planner_common/src/utils/utils.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9044      +/-   ##
==========================================
- Coverage   26.52%   26.52%   -0.01%     
==========================================
  Files        1296     1302       +6     
  Lines       95710    95743      +33     
  Branches    38984    38984              
==========================================
+ Hits        25389    25395       +6     
- Misses      67751    67777      +26     
- Partials     2570     2571       +1     
Flag Coverage Δ *Carryforward flag
differential 15.47% <37.03%> (?)
total 26.52% <ø> (+<0.01%) ⬆️ Carriedforward from 4f97001

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulfaqar-azmi-t4 zulfaqar-azmi-t4 merged commit d4d40cd into autowarefoundation:main Oct 7, 2024
40 of 41 checks passed
@zulfaqar-azmi-t4 zulfaqar-azmi-t4 deleted the refactor-lc-get-lane-change-lanes branch October 7, 2024 09:07
prakash-kannaiah pushed a commit to prakash-kannaiah/autoware.universe that referenced this pull request Oct 9, 2024
…arefoundation#9044)

* refactor(lane_change): refactor get_lane_change_lanes function

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add doxygen comment for to_geom_msg_pose

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Signed-off-by: prakash-kannaiah <prakashkanan.pk@gmail.com>
zulfaqar-azmi-t4 added a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…arefoundation#9044)

* refactor(lane_change): refactor get_lane_change_lanes function

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add doxygen comment for to_geom_msg_pose

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 20, 2024
…arefoundation#9044)

* refactor(lane_change): refactor get_lane_change_lanes function

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add doxygen comment for to_geom_msg_pose

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
kyoichi-sugahara pushed a commit to tier4/autoware.universe that referenced this pull request Dec 21, 2024
…arefoundation#9044)

* refactor(lane_change): refactor get_lane_change_lanes function

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

* Add doxygen comment for to_geom_msg_pose

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>

---------

Signed-off-by: Zulfaqar Azmi <zulfaqar.azmi@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants