refactor(autoware_autonomous_emergency_braking): rename info_marker_publisher to virtual_wall_publisher #9078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ublisher to virtual_wall_publisher Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
kyoichi-sugahara
requested review from
danielsanchezaran,
soblin,
TakaHoribe and
tkimura4
as code owners
github-actions
bot
added
the
component:control
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
kyoichi-sugahara
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9078 +/- ##
==========================================
- Coverage 26.96% 26.95% -0.02%
==========================================
Files 1297 1298 +1
Lines 95780 95807 +27
Branches 39130 39139 +9
==========================================
- Hits 25830 25823 -7
- Misses 67361 67394 +33
- Partials 2589 2590 +1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kyoichi-sugahara
merged commit 543b45e
into
autowarefoundation:main
43 of 44 checks passed
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 24, 2024
…ublisher to virtual_wall_publisher (autowarefoundation#9078) Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 24, 2024
* refactor(autoware_autonomous_emergency_braking): rename info_marker_publisher to virtual_wall_publisher (autowarefoundation#9078) Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> * fix(autonomous_emergency_braking): fix no backward imu path and wrong back distance usage (autowarefoundation#9141) * fix no backward imu path and wrong back distance usage Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> * use the motion utils isDrivingForward function Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> --------- Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp> Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com> Co-authored-by: Kyoichi Sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 28, 2024
…ublisher to virtual_wall_publisher (autowarefoundation#9078) Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
danielsanchezaran
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Nov 14, 2024
…ublisher to virtual_wall_publisher (autowarefoundation#9078) Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
modified the AEB to publish virtual walls in a format that matches the virtual stop walls from the planning module.
If other package in control module inserts stop line, I expect this topic's visual control is placed under the new VirtualWall directory.
The PR for the changes on the autoware_launch side is here.
How was this PR tested?
run psim
original display
updated display
Notes for reviewers
None.
Interface changes
None.