Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_cuda_pointcloud_preprocessor): a cuda-accelerated pointcloud preprocessor #9454

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

chore: updated config, schema, and handled the null case in a special…

6baaea2
Select commit
Loading
Failed to load commit list.
Open

feat(autoware_cuda_pointcloud_preprocessor): a cuda-accelerated pointcloud preprocessor #9454

chore: updated config, schema, and handled the null case in a special…
6baaea2
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) succeeded Jan 23, 2025 in 39s

CodeScene PR Check

✅ Code Health Quality Gates: OK

Code Health of new files: 9.46

  • Declining Code Health: 2 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional cuda_pointcloud_preprocessor_node.cpp: CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode
  • Complex Method cuda_pointcloud_preprocessor_node.cpp: CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode

Annotations

Check warning on line 122 in sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method 

CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 67 in sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional 

CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode has 1 complex conditionals with 4 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
View more details on CodeScene Delta Analysis