Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_carla_interface): fix lidar topic name #9645

Conversation

maxime-clem
Copy link
Contributor

Description

Fix the lidar topic name so that it matches the topics used by the awsim_labs_sensor_kit.
The breaking change was introduced by autowarefoundation/awsim_labs_sensor_kit_launch#6

Related links

Issue was originally reported here: https://github.com/orgs/autowarefoundation/discussions/5527#discussioncomment-11455499

How was this PR tested?

With CARLA.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
@maxime-clem maxime-clem added the simulator:carla Issue related to CARLA simulator label Dec 13, 2024
@github-actions github-actions bot added the component:simulation Virtual environment setups and simulations. (auto-assigned) label Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@maxime-clem maxime-clem added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 14, 2024
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.77%. Comparing base (a32cae1) to head (8c3f72c).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9645   +/-   ##
=======================================
  Coverage   28.77%   28.77%           
=======================================
  Files        1457     1457           
  Lines      109221   109221           
  Branches    42566    42566           
=======================================
+ Hits        31428    31432    +4     
+ Misses      74714    74708    -6     
- Partials     3079     3081    +2     
Flag Coverage Δ *Carryforward flag
differential 0.00% <ø> (?)
total 28.77% <ø> (+<0.01%) ⬆️ Carriedforward from 77c1a3f

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxime-clem maxime-clem merged commit ca2d4e7 into autowarefoundation:main Jan 6, 2025
34 checks passed
@maxime-clem maxime-clem deleted the fix/carla_interface-lidar_topic_name branch January 6, 2025 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) simulator:carla Issue related to CARLA simulator
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants