Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set Eigen include directory as SYSTEM for Humble arm64 #978

Merged
merged 1 commit into from
May 26, 2022

Conversation

kenji-miyake
Copy link
Contributor

@kenji-miyake kenji-miyake commented May 26, 2022

Description

To resolve this error with Humble arm64.
https://github.com/autowarefoundation/autoware/runs/6612576310?check_suite_focus=true#step:6:5286

Related: autowarefoundation/autoware_common#76

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
@kenji-miyake kenji-miyake requested review from esteve, xmfcx and wep21 May 26, 2022 17:19
@kenji-miyake kenji-miyake mentioned this pull request May 26, 2022
4 tasks
@kenji-miyake kenji-miyake enabled auto-merge (squash) May 26, 2022 17:29
@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

Merging #978 (80f412c) into main (341170a) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #978   +/-   ##
=====================================
  Coverage   9.55%   9.55%           
=====================================
  Files        941     941           
  Lines      58313   58313           
  Branches   10577   10577           
=====================================
  Hits        5570    5570           
  Misses     48024   48024           
  Partials    4719    4719           
Flag Coverage Δ *Carryforward flag
differential 9.31% <ø> (?)
total 9.55% <ø> (ø) Carriedforward from 341170a

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 341170a...80f412c. Read the comment docs.

@kenji-miyake kenji-miyake merged commit 75b3529 into main May 26, 2022
@kenji-miyake kenji-miyake deleted the set-eigen-include-dir-as-system branch May 26, 2022 18:19
@esteve
Copy link
Contributor

esteve commented May 26, 2022

@kenji-miyake thanks for going through all the packages and updating them to use include_directories 🙂

ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Jun 7, 2022
…foundation#978)

Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Sep 28, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 3, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
boyali referenced this pull request in boyali/autoware.universe Oct 19, 2022
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
saka1-s pushed a commit to saka1-s/autoware.universe that referenced this pull request Nov 28, 2023
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
iwatake2222 pushed a commit to iwatake2222/autoware.universe that referenced this pull request Jan 17, 2025
…for aeb (autowarefoundation#978)

* rebase to awf main

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* set debug PC as false

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* dictionary

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* eliminate duplicate parameter

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

* eliminate duplicate parameter

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>

---------

Signed-off-by: Daniel Sanchez <danielsanchezaran@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants