Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_static_centerline_generator): fix bugprone-exception-escape #9805

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

kobayu858
Copy link
Contributor

Description

This is a fix based on clang-tidy bugprone-exception-escape error.

/home/emb4/autoware/autoware/src/universe/autoware.universe/planning/autoware_static_centerline_generator/src/main.cpp:20:5: error: an exception may be thrown in function 'main' which should not throw exceptions [bugprone-exception-escape,-warnings-as-errors]
int main(int argc, char * argv[])
    ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: kobayu858 <yutaro.kobayashi@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Dec 26, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@kobayu858 kobayu858 requested a review from veqcc December 26, 2024 10:56
@kobayu858 kobayu858 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 29.66%. Comparing base (b764c57) to head (1ce1930).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
.../autoware_static_centerline_generator/src/main.cpp 56.25% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9805      +/-   ##
==========================================
- Coverage   29.68%   29.66%   -0.02%     
==========================================
  Files        1450     1458       +8     
  Lines      108833   108907      +74     
  Branches    42740    42746       +6     
==========================================
+ Hits        32305    32307       +2     
- Misses      73357    73429      +72     
  Partials     3171     3171              
Flag Coverage Δ *Carryforward flag
differential 9.05% <56.25%> (?)
total 29.67% <ø> (-0.01%) ⬇️ Carriedforward from b764c57

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kobayu858 kobayu858 merged commit 8048b9e into autowarefoundation:main Dec 27, 2024
47 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants