-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Added functionality to run.sh in docker/generic #1617
[Feature] Added functionality to run.sh in docker/generic #1617
Conversation
@sgermanserrano Thanks for your great job! It seems to work correctly in my environment. But I think I can use a different distribution name on its first argument and tag name, e.g. @kfunaoka I want this function ASAP, please review? |
@sgermanserrano @aohsato I've created a pull request https://github.com/sgermanserrano/Autoware/pull/1 into this pull request. Would you comment my pull request? I can modify or revert any of the changes in my pull request :) Description
Usage
|
|
@kfunaoka I think your modification seems to be good. Can you upload |
@kfunaoka Btw, you already uploaded |
@aohsato Thanks! Uploaded latest-{kinetic,indigo} that are same as 1.9.0. The Docker images of 1.8.0 can not be built autowarefoundation/autoware_ai#286. I was preparing 1.8.1 autowarefoundation/autoware_ai#345, but it is obsolete now. I'll consider 1.8.1 if there are some requests. |
Modified functionality to run.sh in docker/generic
@sgermanserrano I tested your PR after merging @kfunaoka 's modification then it greatly works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…undation#1617) * Added functionality to run.sh in docker/generic * Set default tag latest-kinetic * Fix README.md
Status
PRODUCTION
Description
The installation instructions rely on the user modifying the run.sh file to get the correct docker image. This PR adds more functionality to the run.sh to ease getting Autoware running the first time.
By default it pulls the latest image (for either distirbution) from the
autoware/autoware
docker repo but supports changing the repo and/or specifying a particular tag as well as changing the shared directory.Todos
Steps to Test or Reproduce
The run.sh needs to be executed as opposed to called with sh.
sudo ./run.sh kinetic
-> Will attempt to pull and run tag 1.7.0-kinetic from autoware/autowaresudo ./run.sh indigo -t 1.6.2-indigo
-> Will attempt to pull and run tag 1.6.2-indigo from autoware/autowaresudo ./run.sh indigo -t driveworks-kinetic-20180809 -r autoware/build
-> Will attempt to pull and run tag driveworks-kinetic-20180809 from autoware/build