Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Added functionality to run.sh in docker/generic #1617

Merged
merged 6 commits into from
Nov 8, 2018
Merged

[Feature] Added functionality to run.sh in docker/generic #1617

merged 6 commits into from
Nov 8, 2018

Conversation

sgermanserrano
Copy link

Status

PRODUCTION

Description

The installation instructions rely on the user modifying the run.sh file to get the correct docker image. This PR adds more functionality to the run.sh to ease getting Autoware running the first time.
By default it pulls the latest image (for either distirbution) from the autoware/autoware docker repo but supports changing the repo and/or specifying a particular tag as well as changing the shared directory.

Todos

  • Documentation: the Wiki needs to be updated

Steps to Test or Reproduce

The run.sh needs to be executed as opposed to called with sh.
sudo ./run.sh kinetic -> Will attempt to pull and run tag 1.7.0-kinetic from autoware/autoware
sudo ./run.sh indigo -t 1.6.2-indigo -> Will attempt to pull and run tag 1.6.2-indigo from autoware/autoware
sudo ./run.sh indigo -t driveworks-kinetic-20180809 -r autoware/build -> Will attempt to pull and run tag driveworks-kinetic-20180809 from autoware/build

@sgermanserrano sgermanserrano changed the title Added functionality to run.sh in docker/generic [Featuer] Added functionality to run.sh in docker/generic Oct 17, 2018
@sgermanserrano sgermanserrano changed the title [Featuer] Added functionality to run.sh in docker/generic [Feature] Added functionality to run.sh in docker/generic Oct 17, 2018
@aohsato
Copy link

aohsato commented Nov 1, 2018

@sgermanserrano Thanks for your great job! It seems to work correctly in my environment.

But I think I can use a different distribution name on its first argument and tag name, e.g. ./run.sh indigo -t 1.7.0-kinetic. How about this?
And we plan to prepare "latest" tag, so perhaps you'll not need your script catching its tag name.

@kfunaoka I want this function ASAP, please review?

@kfunaoka
Copy link

kfunaoka commented Nov 2, 2018

@sgermanserrano @aohsato I've created a pull request https://github.com/sgermanserrano/Autoware/pull/1 into this pull request. Would you comment my pull request? I can modify or revert any of the changes in my pull request :)

Description

  • The first arg indigo|kinetic is removed for the inconsistency @aohsato mentioned, i.e., ./run.sh indigo -t 1.7.0-kinetic
  • Set default tag latest-kinetic
  • Output image name and shared dir info even if tag and repo are not specified
  • Add -h option for help

Usage

  • Option -h outputs Usage: $0 [-t <tag>] [-r <repo>] [-s <Shared directory>]
  • Option -t specifies tag (Default: latest-kinetic)
  • Option -r specifies repo (Default: autoware/autoware)
  • Option -s specifies shared dir (Default: /home/$USER/shared_dir)
  • ./run.sh outputs Using autoware/autoware:latest-kinetic and Shared directory: /home/$USER/shared_dir even if tag and repo are not specified

@kfunaoka
Copy link

kfunaoka commented Nov 2, 2018

latest-kinetic|indigo are not uploaded. I'll once it's OK :)

@aohsato
Copy link

aohsato commented Nov 5, 2018

@kfunaoka I think your modification seems to be good. Can you upload latest-kinetic|indigo? I want to check.
@sgermanserrano Would you please comment to this? I wanna use your scripts in my projects. :)
https://github.com/sgermanserrano/Autoware/pull/1

@aohsato
Copy link

aohsato commented Nov 5, 2018

@kfunaoka Btw, you already uploaded 1.8.0-kinetic|indigo?

@kfunaoka
Copy link

kfunaoka commented Nov 6, 2018

@aohsato Thanks! Uploaded latest-{kinetic,indigo} that are same as 1.9.0.

The Docker images of 1.8.0 can not be built autowarefoundation/autoware_ai#286. I was preparing 1.8.1 autowarefoundation/autoware_ai#345, but it is obsolete now. I'll consider 1.8.1 if there are some requests.

Modified functionality to run.sh in docker/generic
@sgermanserrano
Copy link
Author

@aohsato @kfunaoka apologies for the delay. I have just merged the @kfunaoka modifications to my branch to it is now ready to go :)

@aohsato
Copy link

aohsato commented Nov 6, 2018

@sgermanserrano I tested your PR after merging @kfunaoka 's modification then it greatly works!

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgermanserrano sgermanserrano merged commit 935f5fb into autowarefoundation:develop Nov 8, 2018
@sgermanserrano sgermanserrano deleted the feature/improve_run_sh branch November 8, 2018 10:04
anubhavashok pushed a commit to NuronLabs/autoware.ai that referenced this pull request Sep 7, 2021
…undation#1617)

* Added functionality to run.sh in docker/generic

* Set default tag latest-kinetic

* Fix README.md
@mitsudome-r mitsudome-r added the version:autoware-ai Autoware.AI label Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants