fix(docker): update docker manifest #5310
Draft
+83
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
oguzkaganozt
added
type:containers
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
Signed-off-by: Oguz Ozturk <oguzkaganozt@gmail.com>
|
@youtalk please review now |
youtalk
reviewed
Oct 8, 2024
| amd64_tags=$(printf "%s\n" $ALL_TAGS | grep "\-amd64" | sed "s/-amd64$//g") | ||
| arm64_tags=$(printf "%s\n" $ALL_TAGS | grep "\-arm64" | sed "s/-arm64$//g") | ||
| base_tags=$(printf "%s\n" "$amd64_tags" "$arm64_tags" | sort | uniq) | ||
| echo "All tags: ${{ steps.get-all-tags.outputs.tags }}" |
There was a problem hiding this comment.
I think it would be redundant.
https://github.com/autowarefoundation/autoware/actions/runs/11219103356/job/31184311855#step:3:576
Suggested change
| echo "All tags: ${{ steps.get-all-tags.outputs.tags }}" |
Comment on lines
54
to
56
| - name: Get base tags | ||
| id: get-base-tags | ||
| run: | |
There was a problem hiding this comment.
Can you create a shell script file that performs this process and rewrite this action to just call it? This will improve readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to simplify docker tagging mechanism this PR will do the following things:
amd64andarm64versions found in the packages-amd64,-arm64tags if the combined manifest created succesfully for the corresponding versions in order to eliminate redundant tagsTests performed
https://github.com/autowarefoundation/autoware/actions/runs/11219103356/job/31184311855
Effects on system behavior
Not applicable.
Interface changes
Not applicable.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.