Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

perf(lanelet2_extension): more efficient getLinkedParkingLot #248

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

maxime-clem
Copy link
Contributor

@maxime-clem maxime-clem commented Jun 4, 2024

Description

Improve the getLinkedParkingLot() function so that it does not requiring providing ALL parking lots lanelets.

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@kosuke55 kosuke55 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xmfcx xmfcx force-pushed the perf/getLinkedParkingLot branch from ab354bc to 56898c1 Compare June 14, 2024 11:35
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 17.00%. Comparing base (f01d31c) to head (7be4ad8).
Report is 5 commits behind head on main.

Files Patch % Lines
tmp/lanelet2_extension/lib/query.cpp 0.00% 6 Missing ⚠️
tmp/lanelet2_extension_python/src/utility.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   10.46%   17.00%   +6.54%     
==========================================
  Files          42       49       +7     
  Lines        3154     3170      +16     
  Branches     1409     1469      +60     
==========================================
+ Hits          330      539     +209     
- Misses       2397     2413      +16     
+ Partials      427      218     -209     
Flag Coverage Δ *Carryforward flag
differential 14.33% <0.00%> (?)
total 10.48% <ø> (+0.02%) ⬆️ Carriedforward from f01d31c

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Maxime CLEMENT <maxime.clement@tier4.jp>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants