Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(perception): adopt awsim (tlr) camera topic #1177

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

MasatoSaeki
Copy link
Contributor

@MasatoSaeki MasatoSaeki commented Sep 20, 2024

Description

This PR enable to adopt awsim camera topic.
link

Tests performed

I have checked on AWSIM

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added component:simulation Virtual environment setups and simulations. (auto-assigned) component:perception Advanced sensor data processing and environment understanding. (auto-assigned) labels Sep 20, 2024
@MasatoSaeki MasatoSaeki marked this pull request as ready for review September 20, 2024 08:05
Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

I've rebased this to the latest main. Now testing with AWSIM Labs. https://github.com/autowarefoundation/AWSIM-Labs/releases

@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

2024-09-20_15-29_1
2024-09-20_15-29

Works with the latest AWSIM Labs 👍

@xmfcx xmfcx merged commit 42409e3 into autowarefoundation:main Sep 20, 2024
13 checks passed
@xmfcx
Copy link
Contributor

xmfcx commented Sep 20, 2024

@MasatoSaeki -san please next time test with AWSIM Labs.

AWSIM Labs is much more advanced, faster, lighter and with more features than the original AWSIM.

And it works with the main branch of the Autoware.

@MasatoSaeki
Copy link
Contributor Author

@xmfcx
Thank you for your working and input!
It sounds good, I will try that.

MasatoSaeki added a commit to tier4/autoware_launch that referenced this pull request Sep 20, 2024
)

Signed-off-by: MasatoSaeki <masato.saeki@tier4.jp>
@MasatoSaeki MasatoSaeki deleted the fix/tlr_on_awsim branch October 28, 2024 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) component:simulation Virtual environment setups and simulations. (auto-assigned) run:build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants