docs(message-guidelines): link message guidelines #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xmfcx
force-pushed
the
message-guidelines
branch
from
abff6ed to
0b0fff3
Compare
|
Following #11 (comment) @isamu-takagi I've added the enumerations section. |
xmfcx
force-pushed
the
message-guidelines
branch
from
df1fc4c to
3e1e8db
Compare
|
I've moved it to here for more visibility: autowarefoundation/autoware-documentation#94 And this PR just adds a link to it once that is merged. |
xmfcx
changed the title
|
Is this |
|
@kenji-miyake could you review it please? |
added 2 commits
May 9, 2022 17:09
Signed-off-by: M. Fatih Cırıt <mfc@leodrive.ai>
kenji-miyake
changed the title
kenji-miyake
approved these changes
May 10, 2022
|
Ah, but since auto-merge is set, it seems not affected if I changed the title. 😞 https://github.com/autowarefoundation/autoware_msgs/commits/main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've separated the message guidelines to its own PR.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.