Refactor for new memory syncronization API #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor code CUDA and Native backend to match #autumnai/collenchyma/62 that provides enchanced memory management and syncronization. Since memory management is now automatic, `*_plain` variants of functions are removed. BREAKING CHANGE: *_plain versions of API functions are removed, arguments of their counterpart functions may have changed in mutablity. REFERENCE: autumnai/collenchyma#37, autumnai/collenchyma#62
alexandermorozov
force-pushed
the
refactor-sync
branch
from
1c25b02
to
369b51c
Compare
Fix tests and benches to work with new memory management API. Refactor functions for writing data to tensors and checking their contents. Merge set up stage and compute/verify stage: it's much nicer to see input and output values in one place. Refactor tests to be generic on backend and use macros to eliminate repetitive test definitions.
alexandermorozov
force-pushed
the
refactor-sync
branch
from
369b51c
to
84c6666
Compare
|
It turned out I forgot to fix benches. Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on autumnai/collenchyma#62.
Some tests fail on my machine the same way as they fail on master, see #14.