We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The ordering of the stride and padding is inconsistent between new_convolution_config andnew_pooling_config`, making their usage unituitive.
stride
padding
new_convolution_config and
fn new_pooling_config( &self, window: &[i32], padding: &[i32], // padding first stride: &[i32], )
fn new_convolution_config( &self, src: &::co::tensor::SharedTensor<f32>, dest: &::co::tensor::SharedTensor<f32>, filter: &mut ::co::tensor::SharedTensor<f32>, stride: &[i32], // stride first zero_padding: &[i32], )
We should decide on one ordering and use that consistently. Are there any other function signatures that could be affected by this?
The text was updated successfully, but these errors were encountered:
feat/pooling: stride before padding argument
4ae37c0
The original issue is autumnai/collenchyma-nn#9
No branches or pull requests
The ordering of the
stride
andpadding
is inconsistent betweennew_convolution_config and
new_pooling_config`, making their usage unituitive.We should decide on one ordering and use that consistently.
Are there any other function signatures that could be affected by this?
The text was updated successfully, but these errors were encountered: