Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameter ordering is inconsistent between pooling and convolution #9

Open
hobofan opened this issue Jan 6, 2016 · 0 comments
Open

Comments

@hobofan
Copy link
Member

hobofan commented Jan 6, 2016

The ordering of the stride and padding is inconsistent between new_convolution_config andnew_pooling_config`, making their usage unituitive.

    fn new_pooling_config(
        &self,
        window: &[i32],
        padding: &[i32], // padding first
        stride: &[i32],
    )
    fn new_convolution_config(
        &self,
        src: &::co::tensor::SharedTensor<f32>,
        dest: &::co::tensor::SharedTensor<f32>,
        filter: &mut ::co::tensor::SharedTensor<f32>,
        stride: &[i32], // stride first
        zero_padding: &[i32],
    )

We should decide on one ordering and use that consistently.
Are there any other function signatures that could be affected by this?

@hobofan hobofan added the bug label Jan 6, 2016
drahnr pushed a commit to fff-rs/coaster-nn that referenced this issue Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant