Move to stable #10
Move to stable #10
Conversation
Replace associated ID consts by a static function. This allows removal of the associated_consts feature flag.
This feature is unused and can be removed
This feature is unused.
Replace StaticMutex by the stable `lazy_static!`
|
That looks really nice! Running on stable wasn't really a focus, but if we can it with such noninvasive changes, why not? :) I didn't know about lazy_static, but I think it can also be used for a few other areas in Collenchyma, like the compilation of OpenCL/CUDA kernels which usually have to happen at runtime. Concerning test, they should be fixed on the latest develop, which I'll merge into master later today. Do you think that we should add some instructions concerning rblas for running on stable to the README? Apart from that it looks good to merge. |
|
I wouldn't add instructions regarding rblas to the README, as mikkyang/rust-blas#12 is merged and the version bumped, but no release cut yet. I would wait for that. |
|
mikkyang/rust-blas#12 (comment) rblas is now on 0.0.11, I added the changed cargo-file. |
|
Nice! 👍 |
|
@homu r+ |
|
📌 Commit f14c1fc has been approved by |
|
⚡ Test exempted - status |
Move to stable This PR removes unnecessary use of feature flags that bar using Rust on stable([1])([2]) compilers. Reasons being: * associated consts (Tracking issue: rust-lang/rust#29646) are currently buggy and can be replaced by an fn in that case. * associated_type_defaults can be removed without breakage * unboxed_closures can be removed without breakage * StaticMutex has an uncertain future (rust-lang/rust#27717) and can be emulated in that case by using `lazy_static!` (correct me if I'm wrong) Finally, I must admit that I didn't get the test suite running quickly. ([1]) Outstanding: this doesn't _quite_ work on stable yet, as some APIs in use are currently making their way through beta, so they are not feature gated, but also not available in 1.4.0. 1.5.0 beta works and as 1.5.0 is 2 weeks away, this is probably not worth the effort. ([2]) rblas is not on stable yet, see mikkyang/rust-blas#12 for that. You can use that version of rust-blas by checking it out from my https://github.com/skade/rust-blas/ and dropping the following `.cargo/config` in your repository: ``` paths = ["/path/to/rblas/checkout"] ```
This PR removes unnecessary use of feature flags that bar using Rust on stable([1])([2]) compilers.
Reasons being:
associated_constsfeature rust-lang/rust#29646) are currently buggy and can be replaced by an fn in that case.lazy_static!(correct me if I'm wrong)Finally, I must admit that I didn't get the test suite running quickly.
([1]) Outstanding: this doesn't quite work on stable yet, as some APIs in use are currently making their way through beta, so they are not feature gated, but also not available in 1.4.0. 1.5.0 beta works and as 1.5.0 is 2 weeks away, this is probably not worth the effort.
([2]) rblas is not on stable yet, see mikkyang/rust-blas#12 for that. You can use that version of rust-blas by checking it out from my https://github.com/skade/rust-blas/ and dropping the following
.cargo/configin your repository: