Skip to content

Commit

Permalink
fix: drop PHP versions 7.1 and 7.2 (#22)
Browse files Browse the repository at this point in the history
contributors: @cHeeSaW
  • Loading branch information
cawolf authored Apr 9, 2021
1 parent 4d631bc commit 5a97983
Show file tree
Hide file tree
Showing 9 changed files with 18 additions and 18 deletions.
12 changes: 6 additions & 6 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,18 +21,18 @@ jobs:
strategy:
matrix:
include:
- php: '7.1'
- php: '7.3'
symfony: '3.4.*'
- php: '7.4'
symfony: '3.4.*'
- php: '7.2'
- php: '7.3'
symfony: '4.4.*'
- php: '7.4'
symfony: '4.4.*'
- php: '7.2'
symfony: '5.1.*'
- php: '7.3'
symfony: '5.2.*'
- php: '7.4'
symfony: '5.1.*'
symfony: '5.2.*'
steps:
- name: checkout
uses: actions/checkout@v2
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
symfony:
- '3.4.*'
- '4.4.*'
- '5.1.*'
- '5.2.*'
steps:
- name: checkout
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion Tests/DependencyInjection/OpentracingExtensionTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class OpentracingExtensionTest extends TestCase
{
private $subject;

public function setUp()
public function setUp(): void
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion Tests/Factory/JaegerStaticConfigFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class JaegerStaticConfigFactoryTest extends TestCase
{
private $subject;

public function setUp()
public function setUp(): void
{
parent::setUp();

Expand Down
2 changes: 1 addition & 1 deletion Tests/Factory/JaegerTracerFactoryTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ class JaegerTracerFactoryTest extends TestCase
private $samplerClass;
private $samplerValue;

public function setUp()
public function setUp(): void
{
parent::setUp();
$this->logger = $this->prophesize(LoggerInterface::class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function __construct(TracingId $tracingId)
$this->tracingId = $tracingId;
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$output->writeln($this->tracingId->getAsString());
return 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public function __construct(TracingId $tracingId)
$this->tracingId = $tracingId;
}

protected function execute(InputInterface $input, OutputInterface $output)
protected function execute(InputInterface $input, OutputInterface $output): int
{
$output->writeln($this->tracingId->getAsString());
return 0;
Expand Down
2 changes: 1 addition & 1 deletion Tests/Internal/JaegerTracingIdTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class JaegerTracingIdTest extends TestCase
/** @var JaegerTracingId */
private $subject;

public function setUp()
public function setUp(): void
{
parent::setUp();
$this->tracing = $this->prophesize(Tracing::class);
Expand Down
2 changes: 1 addition & 1 deletion Tests/OpentracingBundleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class OpentracingBundleTest extends TestCase
/** @var OpentracingBundle */
private $subject;

public function setUp()
public function setUp(): void
{
parent::setUp();

Expand Down
10 changes: 5 additions & 5 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@
"auxmoney/opentracing-bundle-tracer-implementation": "*"
},
"require": {
"php": "^7.1.33",
"php": "^7.3.27",
"ext-json": "*",
"auxmoney/opentracing-bundle-core": "^0.7",
"auxmoney/opentracing-bundle-core": "^0.8",
"opentracing/opentracing": "1.0.0-beta5@beta",
"jukylin/jaeger-php": "^2.1.3"
},
Expand All @@ -28,12 +28,12 @@
"phpunit/phpunit": "^7.5",
"phpstan/phpstan": "^0.12",
"squizlabs/php_codesniffer": "^3.5",
"phpmd/phpmd": "^2.7",
"php-coveralls/php-coveralls": "^2.2",
"phpmd/phpmd": "^2.9",
"php-coveralls/php-coveralls": "^2.4",
"symfony/filesystem": "*",
"symfony/process": "*",
"symfony/yaml": "*",
"mtdowling/jmespath.php": "^2.5"
"mtdowling/jmespath.php": "^2.6"
},
"autoload": {
"psr-4": {
Expand Down

0 comments on commit 5a97983

Please sign in to comment.