Add C API const qualifiers #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackPierce
reviewed
Jun 2, 2020
| unsafe { | ||
| core::intrinsics::abort(); | ||
| } | ||
| core::intrinsics::abort(); |
There was a problem hiding this comment.
What happened to make this okay to call without an unsafe block? The documentation still lists this function as unsafe. (Same question for below)
There was a problem hiding this comment.
Ran across this while cleaning up the warnings:
warning: unnecessary `unsafe` block
--> src/lib.rs:232:5
|
232 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
|
= note: `#[warn(unused_unsafe)]` on by default
warning: unnecessary `unsafe` block
--> src/lib.rs:240:5
|
240 | unsafe {
| ^^^^^^ unnecessary `unsafe` block
warning: 2 warnings emitted
Finished dev [unoptimized + debuginfo] target(s) in 0.48s
I haven't chased this one down yet, wonder if we should instead decorate them with allow(unused_unsafe) for now?
There was a problem hiding this comment.
I believe I found the relevant change. rust-lang/rust#72204. Hasn't hit stable, but c'est la vie. No change necessary here.
ZackPierce
reviewed
Jun 2, 2020
| @@ -539,20 +538,12 @@ impl<'a> DynamicHistory<'a> { | |||
| if external_clock.count == 0 { | |||
| continue; | |||
| } | |||
| let id: TracerId = match external_clock.id.try_into() { | |||
There was a problem hiding this comment.
Good catch that this check isn't strictly necessary anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.