Update PrecompileGen tutorial to use create precompile script #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
3953d73
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2084cd91.avalanche-docs.pages.dev |
| Branch Preview URL: | https://precompilegen-script-update.avalanche-docs.pages.dev |
This was referenced Feb 5, 2023
ceyonur
approved these changes
Feb 6, 2023
ceyonur
requested changes
Feb 6, 2023
darioush
approved these changes
Feb 6, 2023
anusha-ctrl
approved these changes
Feb 6, 2023
yulin-dong
approved these changes
Feb 6, 2023
|
Hmm I think we should have waited a release for subnet-evm before merging this? What do you say? @aaronbuchwald |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the PrecompileGen tutorial to use the new script
./scripts/create_precompile.shinstead of directly running it with thego run ...command.This change was made to address ava-labs/subnet-evm#483.
Since we use the blst library in AvalancheGo, we need to set a CGO flag when compiling/running subnet-evm on some OSs. I have not been able to reproduce this bug, so we should hold off on merging this PR until the reporter confirms that this resolves the issue and the corresponding subnet-evm PR gets merged.