Skip to content

Add validator_weight and delegation_fee to P-Chain staking operation metadata #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Nov 13, 2025
Merged

Add validator_weight and delegation_fee to P-Chain staking operation metadata #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8efa327
adding validator_weight field to P-chain staking operation metadata
camharris Oct 17, 2025
121d162
adding delegation_fee to REWARD_VALIDATOR operation
camharris Oct 17, 2025
96f14c6
add missing fields to tests
camharris Oct 21, 2025
c5c4d5d
fix: Update golangci-lint config for v1.62+ compatibility
camharris Oct 21, 2025
0f5fedf
excluding client from typecheck
camharris Oct 23, 2025
121833d
fix exclude-rules path
camharris Oct 23, 2025
264dad4
correct linter yml
camharris Oct 27, 2025
9f02c34
excluding client direct from all linters
camharris Oct 27, 2025
7fb8d13
properly addressing lint issues by adding missing methods
camharris Oct 27, 2025
d17e690
reverting adding missing methods
camharris Oct 28, 2025
39c8866
re-enable typecheck
camharris Oct 28, 2025
658c35a
fix
camharris Oct 28, 2025
ceffe0d
Merge branch 'master' into feat/add-validator-weight-metadata
rajranjan0608 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions mapper/pchain/tx_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,9 +387,17 @@ func addValidatorMetadataToStakeOuts(ops *txOps, validator txs.ValidatorTx, star
out.Metadata[MetadataValidatorNodeID] = validator.NodeID().String()
out.Metadata[MetadataStakingStartTime] = uint64(startTime.Unix())
out.Metadata[MetadataStakingEndTime] = uint64(validator.EndTime().Unix())
out.Metadata[MetadataValidatorWeight] = validator.Weight()
out.Metadata[MetadataValidatorRewardsOwner] = getAddressArray(validator.ValidationRewardsOwner().(*secp256k1fx.OutputOwners), hrp)
out.Metadata[MetadataDelegationRewardsOwner] = getAddressArray(validator.DelegationRewardsOwner().(*secp256k1fx.OutputOwners), hrp)
out.Metadata[MetadataSubnetID] = validator.SubnetID().String()

switch v := validator.(type) {
case *txs.AddValidatorTx:
out.Metadata[MetadataDelegationFee] = v.DelegationShares
case *txs.AddPermissionlessValidatorTx:
out.Metadata[MetadataDelegationFee] = v.DelegationShares
}
}
}

Expand All @@ -402,6 +410,7 @@ func addDelegatorMetadataToStakeOuts(ops *txOps, delegator txs.DelegatorTx, star
out.Metadata[MetadataValidatorNodeID] = delegator.NodeID().String()
out.Metadata[MetadataStakingStartTime] = uint64(startTime.Unix())
out.Metadata[MetadataStakingEndTime] = uint64(delegator.EndTime().Unix())
out.Metadata[MetadataValidatorWeight] = delegator.Weight()
out.Metadata[MetadataDelegatorRewardsOwner] = getAddressArray(delegator.RewardsOwner().(*secp256k1fx.OutputOwners), hrp)
out.Metadata[MetadataSubnetID] = delegator.SubnetID().String()
}
Expand Down
16 changes: 16 additions & 0 deletions mapper/pchain/tx_parser_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,11 @@ func TestMapAddValidatorTx(t *testing.T) {
require.Equal(2, cntInputMeta)
require.Zero(cntOutputMeta)
require.Equal(1, cntMetaType)

stakeOutOp := rosettaTransaction.Operations[2]
require.Equal(OpTypeStakeOutput, stakeOutOp.Metadata["type"])
require.Equal(uint64(2000000000), stakeOutOp.Metadata[MetadataValidatorWeight])
require.Equal(uint32(20000), stakeOutOp.Metadata[MetadataDelegationFee])
}

func TestMapAddPermissionlessValidatorTx(t *testing.T) {
Expand Down Expand Up @@ -209,6 +214,11 @@ func TestMapAddPermissionlessValidatorTx(t *testing.T) {
require.Equal(2, cntInputMeta)
require.Zero(cntOutputMeta)
require.Equal(1, cntMetaType)

stakeOutOp := rosettaTransaction.Operations[2]
require.Equal(OpTypeStakeOutput, stakeOutOp.Metadata["type"])
require.Equal(uint64(2000000000), stakeOutOp.Metadata[MetadataValidatorWeight])
require.Equal(uint32(20000), stakeOutOp.Metadata[MetadataDelegationFee])
}

// TODO: Remove Post-Durango
Expand Down Expand Up @@ -262,6 +272,9 @@ func TestMapAddDelegatorTx(t *testing.T) {
require.Equal(OpTypeInput, rosettaTransaction.Operations[0].Metadata["type"])
require.Equal(OpTypeOutput, rosettaTransaction.Operations[1].Metadata["type"])
require.Equal(OpTypeStakeOutput, rosettaTransaction.Operations[2].Metadata["type"])

stakeOutOp := rosettaTransaction.Operations[2]
require.Equal(uint64(1000000000), stakeOutOp.Metadata[MetadataValidatorWeight])
}

func TestMapAddPermissionlessDelegatorTx(t *testing.T) {
Expand Down Expand Up @@ -314,6 +327,9 @@ func TestMapAddPermissionlessDelegatorTx(t *testing.T) {
require.Equal(OpTypeInput, rosettaTransaction.Operations[0].Metadata["type"])
require.Equal(OpTypeOutput, rosettaTransaction.Operations[1].Metadata["type"])
require.Equal(OpTypeStakeOutput, rosettaTransaction.Operations[2].Metadata["type"])

stakeOutOp := rosettaTransaction.Operations[2]
require.Equal(uint64(1000000000), stakeOutOp.Metadata[MetadataValidatorWeight])
}

func TestMapImportTx(t *testing.T) {
Expand Down
2 changes: 2 additions & 0 deletions mapper/pchain/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const (
MetadataValidatorNodeID = "validator_node_id"
MetadataStakingStartTime = "staking_start_time"
MetadataStakingEndTime = "staking_end_time"
MetadataValidatorWeight = "validator_weight"
MetadataDelegationFee = "delegation_fee"
MetadataMessage = "message"
MetadataSigner = "signer"

Expand Down
3 changes: 3 additions & 0 deletions service/backend/pchain/construction_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,8 @@ func TestAddValidatorTxConstruction(t *testing.T) {
"delegation_rewards_owner": []string{ewoqAccountP.Address},
"validator_rewards_owner": []string{ewoqAccountP.Address},
"signer": pop,
"validator_weight": uint64(2_000_000_000_000),
"delegation_fee": shares,
},
},
}
Expand Down Expand Up @@ -839,6 +841,7 @@ func TestAddDelegatorTxConstruction(t *testing.T) {
"validator_node_id": nodeID,
"subnet_id": pChainID.String(),
"delegator_rewards_owner": []string{ewoqAccountP.Address},
"validator_weight": uint64(25_000_000_000),
},
},
}
Expand Down