Add tests for race conditions in merkledb #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome contribution, @kyl27 ❤️ . We'll take a look at this tomorrow. In the meantime, I enabled unit tests on the PR! |
darioush
reviewed
Mar 28, 2023
There was a problem hiding this comment.
@kyl27 Thank you for contributing tests. I added a couple comments.
We can also consider adding parallelism to the tests that use randTestStep here @dboehm-avalabs.
StephenButtolph
added
testing
That is a good idea, though I'd probably like to make it a controllable parameter so that the reproducibility of the existing tests is preserved. |
dhrubabasu
reviewed
Mar 29, 2023
darioush
requested changes
Mar 29, 2023
|
Added an additional test for GetRangeProof() |
darioush
approved these changes
Mar 30, 2023
kyl27
commented
Mar 30, 2023
danlaine
approved these changes
Mar 31, 2023
StephenButtolph
approved these changes
Mar 31, 2023
Co-authored-by: Stephen Buttolph <stephen@avalabs.org>
StephenButtolph
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
These tests perform concurrent reads/writes in x/merkledb to ensure there are no race conditions. Given that merkledb is under active development and will be used as a fundamental component in upcoming features such as HyperSDK, we should ensure that it has as many diverse tests as possible, covering all aspects of correctness and performance.
How this works
The golang testing framework provides the -race parameter, which allows it to perform analysis at runtime to test check for data races between go routines. These tests create multiple go routines that perform concurrent data read/writes in x/merkledb.
How this was tested
These new tests pass. Although these tests do not exhaustively check for data races between all combinations of concurrent calls to merkledb/trieView, they do check for several common access patterns.