special case no sent/received message in network health check #1263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
lastSend and lastReceived time values default to 0, which would show errors in health check like:
466123h20m46.862257771s > 1m0s
seems a bit off.This PR handles this case, so that we won't show
time.Now
intimeSinceLastMsgReceived/Sent
and show them like:How this works
Special cases the case where last send/received = 0 in network health function. It also puts storing/reading these values into functions.
How this was tested
Locally tested