Expose GetEngineManager from the chain Handler #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Apr 10, 2023
StephenButtolph
added
consensus
joshua-kim
reviewed
Apr 10, 2023
| @@ -169,6 +170,10 @@ func (h *handler) SetEngineManager(engineManager *EngineManager) { | |||
| h.engineManager = engineManager | |||
| } | |||
|
|
|||
| func (h *handler) GetEngineManager() *EngineManager { | |||
There was a problem hiding this comment.
I think we don't need to hold the ctx.Lock on Set since we only call it when setting up the chain (where the lock is already held in the caller), but do we need to hold the lock here?
There was a problem hiding this comment.
We only modify the value when calling SetEngineManager - so this var isn't written in other cases... so it should be fine not to lock here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
We need access to the engine manager to override the engine manager inside of the custom node testing framework.
How this works
Exposes
GetEngineManageron thehandler.Handlerinterface.How this was tested
N/A