Remove check for impossible condition in x/sync
#1348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darioush
reviewed
Apr 14, 2023
| func (c *networkClient) Request(ctx context.Context, nodeID ids.NodeID, request []byte) ([]byte, error) { | ||
| // TODO danlaine: is it possible for this condition to occur? | ||
| if nodeID == ids.EmptyNodeID { | ||
| return nil, fmt.Errorf("cannot send request to empty nodeID, nodeID=%s, requestLen=%d", nodeID, len(request)) |
Contributor
There was a problem hiding this comment.
This seems like a useful check to leave on the exported method, I think.
Even if all current uses are correct it might catch errors in future development.
Not very strongly opinionated, happy to defer to @dboehm-avalabs
dboehm-avalabs
approved these changes
Apr 17, 2023
darioush
approved these changes
Apr 17, 2023
maru-ava
pushed a commit
that referenced
this pull request
Nov 20, 2025
Signed-off-by: Jonathan Oppenheimer <147infiniti@gmail.com> Co-authored-by: Austin Larson <78000745+alarso16@users.noreply.github.com>
maru-ava
pushed a commit
that referenced
this pull request
Dec 3, 2025
This doesn't totally complete #1113 since I didn't touch the Proof or Iterator files. However, this does clarify a lot of the use cases, and what is valid for concurrent operations. The best way to review this is open the godocs and reading through it, commenting on what doesn't seem clear. To reproduce the godocs, run: ``` cd ./ffi godoc -http=:<PORT_NUM> ``` Please leave nit-picky comments! It would be great if any reader of the docs would know how to use the code. Closes #1348, #1413
JonathanOppenheimer
pushed a commit
that referenced
this pull request
Dec 3, 2025
* update avalanchego dep branch * fix upgrades after deactivating latest in context * use branch commit for ava version * bump avago * bump go * restore format changes --------- Signed-off-by: Ceyhun Onur <ceyhun.onur@avalabs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
The node ID should never be empty
How this works
Self explanatory
How this was tested
Existing UT