[PVM] Unlock deposit refactoring #1480
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Config] cleanup unused vars
* Fix git CI * Make tests executable * Replace assert with require * Remove rockdb tag from test script
…enaming A lot of renaming Removed multi-asset support Optimized Lock() with sorting and merging loops together, added outs compacting Added VerifyLock method Add tests for lock, unlockUTXOs, VerifyLockUTXOs and add test helper functions Updated Unlock method to use state.Chain intf for fetching locked utxos, added state mocks
Added platformVM locked out/in and utxos locking/unlocking with different lock states
Camino Genesis / Config
CaminoExecutor
[PVM StaticService] Fix camino genesis transport
…Addr, added camino lockMode verify ins/outs
Add caminoBuilder and caminoAddValidatorTx
Add VerifyNoLocks method, reduce branching in VerifyLockMode
…implified tests for them to reduce import
Moved VerifyLockMode and VerifyNoLocks from utxo to locked package
…ardsImportTx executor Make CrossChainAppRequest handler return no error if it wasn't able to add tx to mempool. Error in handler will result in fatal and crash every node that did it (whole network)
…o min/maxStakeDuration
* Changed camino chain config to set the min/max values for validation period to 1/2 year to 5 years. Updated the camino genesis to the latest generated state. Updated all test-cases which check the genesis related hashes to the new values. * Updated camino genesis to the latest state. Updated hash tests to the new genesis file. * Updated genesis: Bucket naming Listing => IEO. Also updated hash based tests for genesis validation. * Also updated columbus to the latest state derived from the camino genesis. Including hash based tests.
What has been changed in the genesis-files: general: * Change allocation memo to following format (dropping the single-quotes): ID:, Bucket:, Type: <...> * Cleanup of all IDs to prevent collisions between Camino + Kopernikus on Columbus (Which is a mix of both definitions) -- * Kopernikus IDs are now in general >1000 for both allocations and msig accounts * Cleanup+Sync of all columns and sanity checks in all genesis origin files camino: * Add pre-funded KYC Admin in "01 ADMIN" bucket * Removed some consortium members which have not agreed to host a validator later columbus: * Add pre-funded KYC Admin in "01 ADMIN" bucket * Change chain-start to be in sync with camino * Use the latest state of kopernikus to be in sync with the test accounts kopernikus: * Reuse existing KYC admin to align with camino/columbus * Change chain-start to be in sync with camino * Remove some obsolete personal test accounts * Adjust allocation offsets to be aligned with camino (either 0 or 61 days) * Changed msig-multioffer account to actually use multisig (threshold =2) and added a few more different deposits to it (Note that with kopernikus changes not the local kopernikus file is meant but the one located in camino-node)
hexfusion
pushed a commit
to hexfusion/avalanchego
that referenced
this pull request
Jun 22, 2023
maru-ava
pushed a commit
that referenced
this pull request
Dec 3, 2025
…anager` (#1482) In preparation of moving in-memory revisions to their own data structure (#1470), this PR moves creation of `RootStore` into the `RevisionManager` - this move will allow us to inject the in-memory revisions data structure into `RootStore` during creation. This PR is a precursor to #1480.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested