Fix unreadable message errors

message/internal_msg_builder.go

@@ -5,6 +5,7 @@
 package message
 
 import (
+	"fmt"
 	"time"
 
 	"github.com/ava-labs/avalanchego/ids"
@@ -65,6 +66,11 @@ type GetStateSummaryFrontierFailed struct {
 	RequestID uint32 `json:"request_id,omitempty"`
 }
 
+func (m *GetStateSummaryFrontierFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d",
+		m.ChainID, m.RequestID)
+}
+
 func (m *GetStateSummaryFrontierFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -94,6 +100,11 @@ type GetAcceptedStateSummaryFailed struct {
 	RequestID uint32 `json:"request_id,omitempty"`
 }
 
+func (m *GetAcceptedStateSummaryFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d",
+		m.ChainID, m.RequestID)
+}
+
 func (m *GetAcceptedStateSummaryFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -124,6 +135,11 @@ type GetAcceptedFrontierFailed struct {
 	EngineType p2p.EngineType `json:"engine_type,omitempty"`
 }
 
+func (m *GetAcceptedFrontierFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d EngineType: %s",
+		m.ChainID, m.RequestID, m.EngineType)
+}
+
 func (m *GetAcceptedFrontierFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -160,6 +176,11 @@ type GetAcceptedFailed struct {
 	EngineType p2p.EngineType `json:"engine_type,omitempty"`
 }
 
+func (m *GetAcceptedFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d EngineType: %s",
+		m.ChainID, m.RequestID, m.EngineType)
+}
+
 func (m *GetAcceptedFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -196,6 +217,11 @@ type GetAncestorsFailed struct {
 	EngineType p2p.EngineType `json:"engine_type,omitempty"`
 }
 
+func (m *GetAncestorsFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d EngineType: %s",
+		m.ChainID, m.RequestID, m.EngineType)
+}
+
 func (m *GetAncestorsFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -232,6 +258,11 @@ type GetFailed struct {
 	EngineType p2p.EngineType `json:"engine_type,omitempty"`
 }
 
+func (m *GetFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d EngineType: %s",
+		m.ChainID, m.RequestID, m.EngineType)
+}
+
 func (m *GetFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -268,6 +299,11 @@ type QueryFailed struct {
 	EngineType p2p.EngineType `json:"engine_type,omitempty"`
 }
 
+func (m *QueryFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d EngineType: %s",
+		m.ChainID, m.RequestID, m.EngineType)
+}
+
 func (m *QueryFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -303,6 +339,11 @@ type AppRequestFailed struct {
 	RequestID uint32 `json:"request_id,omitempty"`
 }
 
+func (m *AppRequestFailed) String() string {
+	return fmt.Sprintf("ChainID: %s RequestID: %d",
+		m.ChainID, m.RequestID)
+}
+
 func (m *AppRequestFailed) GetChainId() []byte {
 	return m.ChainID[:]
 }
@@ -334,6 +375,12 @@ type CrossChainAppRequest struct {
 	Message            []byte `json:"message,omitempty"`
 }
 
+func (m *CrossChainAppRequest) String() string {
+	return fmt.Sprintf(
+		"SourceChainID: %s DestinationChainID: %s EngineType: %d Message: %s",
+		m.SourceChainID, m.DestinationChainID, m.RequestID, m.Message)
+}
+
 func (m *CrossChainAppRequest) GetSourceChainID() ids.ID {
 	return m.SourceChainID
 }
@@ -373,6 +420,12 @@ type CrossChainAppRequestFailed struct {
 	RequestID          uint32 `json:"request_id,omitempty"`
 }
 
+func (m *CrossChainAppRequestFailed) String() string {
+	return fmt.Sprintf(
+		"SourceChainID: %s DestinationChainID: %s EngineType: %d",
+		m.SourceChainID, m.DestinationChainID, m.RequestID)
+}
+
 func (m *CrossChainAppRequestFailed) GetSourceChainID() ids.ID {
 	return m.SourceChainID
 }
@@ -410,6 +463,12 @@ type CrossChainAppResponse struct {
 	Message            []byte `json:"message,omitempty"`
 }
 
+func (m *CrossChainAppResponse) String() string {
+	return fmt.Sprintf(
+		"SourceChainID: %v DestinationChainID: %v EngineType: %v Message: %v",
+		m.SourceChainID, m.DestinationChainID, m.RequestID, m.Message)
+}
+
 func (m *CrossChainAppResponse) GetSourceChainID() ids.ID {
 	return m.SourceChainID
 }
@@ -446,6 +505,12 @@ type Connected struct {
 	NodeVersion *version.Application `json:"node_version,omitempty"`
 }
 
+func (m *Connected) String() string {
+	return fmt.Sprintf(
+		"NodeVersion: %v",
+		m.NodeVersion)
+}
+
 func InternalConnected(nodeID ids.NodeID, nodeVersion *version.Application) InboundMessage {
 	return &inboundMessage{
 		nodeID: nodeID,
@@ -463,6 +528,12 @@ type ConnectedSubnet struct {
 	SubnetID ids.ID `json:"subnet_id,omitempty"`
 }
 
+func (m *ConnectedSubnet) String() string {
+	return fmt.Sprintf(
+		"SubnetID: %v",
+		m.SubnetID)
+}
+
 // InternalConnectedSubnet returns a message that indicates the node with [nodeID] is
 // connected to the subnet with the given [subnetID].
 func InternalConnectedSubnet(nodeID ids.NodeID, subnetID ids.ID) InboundMessage {
@@ -478,6 +549,10 @@ func InternalConnectedSubnet(nodeID ids.NodeID, subnetID ids.ID) InboundMessage
 
 type Disconnected struct{}
 
+func (_ Disconnected) String() string {
+	return ""
+}
+
 func InternalDisconnected(nodeID ids.NodeID) InboundMessage {
 	return &inboundMessage{
 		nodeID:     nodeID,
@@ -491,6 +566,12 @@ type VMMessage struct {
 	Notification uint32 `json:"notification,omitempty"`
 }
 
+func (m *VMMessage) String() string {
+	return fmt.Sprintf(
+		"Notification: %v",
+		m.Notification)
+}
+
 func InternalVMMessage(
 	nodeID ids.NodeID,
 	notification uint32,
@@ -507,6 +588,10 @@ func InternalVMMessage(
 
 type GossipRequest struct{}
 
+func (_ GossipRequest) String() string {
+	return ""
+}
+
 func InternalGossipRequest(
 	nodeID ids.NodeID,
 ) InboundMessage {
@@ -520,6 +605,10 @@ func InternalGossipRequest(
 
 type Timeout struct{}
 
+func (_ Timeout) String() string {
+	return ""
+}
+
 func InternalTimeout(nodeID ids.NodeID) InboundMessage {
 	return &inboundMessage{
 		nodeID:     nodeID,

message/messages.go

@@ -34,12 +34,13 @@ var (
 
 // InboundMessage represents a set of fields for an inbound message
 type InboundMessage interface {
+	fmt.Stringer
 	// NodeID returns the ID of the node that sent this message
 	NodeID() ids.NodeID
 	// Op returns the op that describes this message type
 	Op() Op
 	// Message returns the message that was sent
-	Message() any
+	Message() fmt.Stringer
 	// Expiration returns the time that the sender will have already timed out
 	// this request
 	Expiration() time.Time
@@ -49,12 +50,14 @@ type InboundMessage interface {
 	// BytesSavedCompression returns the number of bytes that this message saved
 	// due to being compressed
 	BytesSavedCompression() int
+	// Returns string representation of message
+	String() string
 }
 
 type inboundMessage struct {
 	nodeID                ids.NodeID
 	op                    Op
-	message               any
+	message               fmt.Stringer
 	expiration            time.Time
 	onFinishedHandling    func()
 	bytesSavedCompression int
@@ -68,7 +71,7 @@ func (m *inboundMessage) Op() Op {
 	return m.op
 }
 
-func (m *inboundMessage) Message() any {
+func (m *inboundMessage) Message() fmt.Stringer {
 	return m.message
 }
 
@@ -86,6 +89,11 @@ func (m *inboundMessage) BytesSavedCompression() int {
 	return m.bytesSavedCompression
 }
 
+func (m *inboundMessage) String() string {
+	return fmt.Sprintf("NodeID: %s Op: %s Message: %s",
+		m.nodeID, m.op, m.message)
+}
+
 // OutboundMessage represents a set of fields for an outbound message that can
 // be serialized into a byte stream
 type OutboundMessage interface {

message/ops.go

@@ -296,7 +296,7 @@ func (op Op) String() string {
 	}
 }
 
-func Unwrap(m *p2p.Message) (interface{}, error) {
+func Unwrap(m *p2p.Message) (fmt.Stringer, error) {
 	switch msg := m.GetMessage().(type) {
 	// Handshake:
 	case *p2p.Message_Ping:

snow/networking/handler/handler.go

@@ -412,7 +412,7 @@ func (h *handler) dispatchChans(ctx context.Context) {
 
 		if err := h.handleChanMsg(msg); err != nil {
 			h.StopWithError(ctx, fmt.Errorf(
-				"%w while processing async message: %s",
+				"%w while processing chan message: %s",
 				err,
 				msg,
 			))

snow/networking/handler/message_queue.go

@@ -32,6 +32,10 @@ type Message struct {
 	EngineType p2p.EngineType
 }
 
+func (m Message) String() string {
+	return m.Message().String()
+}
+
 type MessageQueue interface {
 	// Add a message.
 	//