Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACP-77: Refactor subnet auth verification #3537

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

StephenButtolph
Copy link
Contributor

Why this should be merged

This PR is factored out of #3440.

This PR:

  1. Passes in a more minimum value to the verifyPoASubnetAuthorization helper - by taking in an fx.Fx rather than a *backend.
  2. Allows auth verification to be performed on things other than subnets.

How this works

Introduces a new helper verifyAuthorization.

How this was tested

  • Updated existing tests. (These are only changed because they are poor mock-based tests).

Need to be documented in RELEASES.md?

No.

@StephenButtolph StephenButtolph self-assigned this Nov 11, 2024
@StephenButtolph StephenButtolph added the cleanup Code quality improvement label Nov 11, 2024
@StephenButtolph StephenButtolph added this to the v1.11.13 milestone Nov 11, 2024
Base automatically changed from refactor-p-chain-configs to master November 12, 2024 18:09
@StephenButtolph StephenButtolph added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit a01eaee Nov 12, 2024
23 checks passed
@StephenButtolph StephenButtolph deleted the refactor-subnet-auth-verification branch November 12, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code quality improvement
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants