Add partial-sync support to the wallet #3567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephenButtolph
changed the base branch from
master
to
remove-unused-wallet-interface
StephenButtolph
changed the base branch from
remove-unused-wallet-interface
to
move-required-fields-from-config
StephenButtolph
commented
Nov 25, 2024
| @@ -21,42 +21,40 @@ const gasPriceMultiplier = 2 | |||
|
|
|||
| func NewContextFromURI(ctx context.Context, uri string) (*builder.Context, error) { | |||
| infoClient := info.NewClient(uri) | |||
| xChainClient := avm.NewClient(uri, "X") | |||
There was a problem hiding this comment.
In order to support partial sync, the P-chain wallet can not depend on any X-chain APIs.
yacovm
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Currently, it is not easy to create a wallet that can issue transactions against a node that is running
--partial-sync-primary-network.This PR allows creating an instance of the P-chain wallet against such a node.
How this works
MakePWalletthat does not attempt to fetch UTXOs from the X-chain or C-chain (or shared memory).How this was tested
Issuing transactions against a partial synced node.
Need to be documented in RELEASES.md?
No.