Add already implemented merkledb.View to MerkleDB interface #3593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marun
approved these changes
Dec 16, 2024
darioush
approved these changes
Dec 16, 2024
StephenButtolph
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
merkledb.Viewto themerkledb.MerkleDBinterface. This adds the already implementedCommitToDBfunction to the exported interface.Downstream code (HyperSDK) uses
merkledb.Viewtype to represent the view calculated for an individual block. After committing a view, that view is no longer safe to use and the last committed state is represented directly by theMerkleDBinstance. However, this complicates using the existing interface for the "view" of the last accepted block sinceCommitToDBis not implemented.