fix(crypto/secp256k1): UnmarshalText #4419
Open
+24
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Normally,
x = UnmarshalText(MarshalText(x)). However, this currently fails becauseUnmarshalText()expects a quoted string (as it callsUnmarshalJSON()and JSON marshaling uses quoted strings) whileMarshalText()returns a string without quotes.How this works
Factors out the common logic of
UnmarshalText()andUnmarshalJSON()intounmarshalText()(which expects an unquoted string).UnmarshalJSON()now handles its own quoted string logic.How this was tested
Added a regression test.
Need to be documented in RELEASES.md?
No.