Implement RTT measurement #4454
Merged
+37
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements RTT (Round-Trip Time) measurement for network peers by tracking the time between ping and pong messages. The implementation allows node administrators to monitor network latency to all connected peers, which can help diagnose issues like delayed block acceptance.
Key Changes:
- Added atomic timestamp tracking when ping messages are sent
- Implemented pong message handler to calculate elapsed time and emit RTT metrics
- Added Prometheus counter and gauge metrics for RTT count and sum
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| network/peer/peer.go | Added lastPingSent field, timestamp recording on ping send, and pong handler to calculate RTT |
| network/peer/metrics.go | Added RTTCount and RTTSum Prometheus metrics with registration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This commit implements a Round-Trip-Time measurement by measuring the ping-pong delay. When a ping is sent to a peer `p`, the time is sampled. When a pong is received, the elapsed time is measured and the round_trip_count and round_trip_sum counter and gauge are emitted. Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
Signed-off-by: Yacov Manevich <yacov.manevich@avalabs.org>
StephenButtolph
approved these changes
Nov 3, 2025
alarso16
approved these changes
Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds measurement of round trip time using the ping pong messages.
Why this should be merged
This commit lets the administrators of a node monitor the network round trip time of all peers the network is connected to.
In case the network of the node experiences delay, it will be reflected in this metric and can be used to explain phenomenon such as block acceptance taking too long.
How this works
The Round-Trip-Time is measured by measuring the time between the ping pong messages. When a ping is sent to a peer
p, the time is sampled. When a pong is received, the elapsed time is measured and the round_trip_count and round_trip_sum counter and gauge are emitted.How this was tested
I cherry picked this commit on a Fuji 1.14 node I have deployed a week ago, and re-compiled the node and ran it.
I created in Grafana the dashboard below using the command:
increase(avalanche_network_round_trip_sum[5m]) / increase(avalanche_network_round_trip_count[5m])Need to be documented in RELEASES.md?
No