chore: Cleanup coreth post-merge #4578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alarso16
added
documentation
alarso16
force-pushed
the
alarso16/coreth-cleanup
branch
from
3ac4417 to
94d2010
Compare
alarso16
commented
Nov 25, 2025
Contributor
Author
There was a problem hiding this comment.
This should just be manually rewritten alongside avalanchego's next release
Member
There was a problem hiding this comment.
Can we create an issue for this?
alarso16
requested review from
a team,
StephenButtolph,
joshua-kim,
maru-ava and
meaghanfitzgerald
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs cleanup tasks following the coreth merger into the avalanchego repository. The changes update documentation, file paths, and configurations to reflect coreth's new location within the avalanchego repository structure.
Key changes:
- Updates repository URLs and file paths from standalone coreth repository to the grafted location within avalanchego
- Removes obsolete standalone repository files (GitHub workflows, issue templates, release documentation)
- Consolidates configuration by removing duplicate files now managed at the repository root level
Reviewed changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| vms/example/xsvm/README.md | Updates Coreth reference URL to new location within avalanchego |
| graft/coreth/scripts/dev_shell.sh | Removes obsolete development shell script |
| graft/coreth/scripts/constants.sh | Updates git directory path for commit hash retrieval |
| graft/coreth/go.mod | Simplifies Go version update guidelines by referencing root go.mod |
| graft/coreth/docs/releasing/README.md | Removes standalone release documentation |
| graft/coreth/cmd/simulator/README.md | Updates simulator directory path |
| graft/coreth/SECURITY.md | Updates releases URL to avalanchego repository |
| graft/coreth/README.md | Simplifies build instructions and removes duplicate nix setup documentation |
| graft/coreth/.gitignore | Removes file as gitignore is managed at repository root |
| graft/coreth/.github/workflows/codeql-analysis.yml | Removes duplicate workflow managed at repository root |
| graft/coreth/.github/pull_request_template.md | Removes duplicate template managed at repository root |
| graft/coreth/.github/dependabot.yml | Removes duplicate configuration managed at repository root |
| graft/coreth/.github/ISSUE_TEMPLATE/feature_request.md | Removes duplicate template managed at repository root |
| graft/coreth/.github/ISSUE_TEMPLATE/bug_report.md | Removes duplicate template managed at repository root |
| graft/coreth/.github/CONTRIBUTING.md | Removes duplicate documentation managed at repository root |
| graft/coreth/.github/CODEOWNERS | Removes duplicate file managed at repository root |
| graft/coreth/.dockerignore | Removes file no longer needed |
| go.mod | Adds reference to graft module go.mod files in version update guidelines |
| .github/dependabot.yml | Adds dependabot configuration for coreth module |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
maru-ava
reviewed
Nov 25, 2025
| @@ -1 +1 @@ | |||
| #!/usr/bin/env bash | |||
Contributor
There was a problem hiding this comment.
Is this file still required or could the avalanchego equivalent be used instead?
Contributor
Author
There was a problem hiding this comment.
Most of it is still required. The only shared variable is CGO_FLAGS.
Contributor
There was a problem hiding this comment.
Is it for more than the build script though? And why isn't that just being deleted anyway? afaik we're neither consuming nor releasing a binary artifact for coreth.
| ``` | ||
| Coreth is a dependency of AvalancheGo which is used to implement the EVM based Virtual Machine for the Avalanche C-Chain. In order to run with a local version of Coreth, users can simply build AvalancheGo from source. | ||
|
|
||
| Note: the C-Chain originally ran in a separate process from the main AvalancheGo process and communicated with it over a local gRPC connection. When this was the case, AvalancheGo's build script would download Coreth, compile it, and place the binary into the `avalanchego/build/plugins` directory. |
Member
There was a problem hiding this comment.
Suggested change
| Note: the C-Chain originally ran in a separate process from the main AvalancheGo process and communicated with it over a local gRPC connection. When this was the case, AvalancheGo's build script would download Coreth, compile it, and place the binary into the `avalanchego/build/plugins` directory. |
Comment on lines
17
to
19
| Some activities, such as collecting metrics and logs from the nodes targeted by an e2e | ||
| test run, require binary dependencies. One way of making these dependencies available is | ||
| to use a nix shell which will give access to the dependencies expected by the test |
Member
There was a problem hiding this comment.
Suggested change
| Some activities, such as collecting metrics and logs from the nodes targeted by an e2e | |
| test run, require binary dependencies. One way of making these dependencies available is | |
| to use a nix shell which will give access to the dependencies expected by the test | |
| Some activities, such as collecting metrics and logs from the nodes targeted by an e2e test run, require binary dependencies. One way of making these dependencies available is to use a nix shell which will give access to the dependencies expected by the test |
Member
There was a problem hiding this comment.
The following line you added should also not be hard broken and should be part of the same line.
Member
There was a problem hiding this comment.
(sorry, can't suggested)
|
|
||
| # WARNING: this will use the most recent commit even if there are un-committed changes present | ||
| CORETH_COMMIT="$(git --git-dir="$CORETH_PATH/.git" rev-parse HEAD)" | ||
| CORETH_COMMIT="$(git --git-dir="$GOPATH/src/github.com/ava-labs/avalanchego/.git" rev-parse HEAD)" |
Member
There was a problem hiding this comment.
rename to avalancego commit? seems misleading now.
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
I noticed some cleanup items to be done after the coreth merger, so might as well get them out of the way
How this works
Mostly deletions and file redirects
How this was tested
CI
Need to be documented in RELEASES.md?
No