-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-9266: use forked react-native-webview package #1836
Conversation
@@ -6,6 +6,8 @@ nmHoistingLimits: workspaces | |||
|
|||
nmSelfReferences: false | |||
|
|||
checksumBehavior: update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had to add this to fix the cached package issue in CI.
The remote archive doesn't match the expected checksum
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we can remove it in another pr once the issue above is fixed in ci.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's wait on merging this until we get an approval from security team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Very nice, thank you for the quick turnaround on this!
Description
Ticket: CP-9266
ava-labs/react-native-webview branch
https://github.com/ava-labs/react-native-webview/tree/cp-9266
Screenshots/Videos
camera permission request
XRecorder_01102024_121836.MP4
file download permission request
XRecorder_01102024_131329.MP4
Checklist
Please check all that apply (if applicable)