Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-9266: use forked react-native-webview package #1836

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Conversation

ruijialin-avalabs
Copy link
Contributor

@ruijialin-avalabs ruijialin-avalabs commented Sep 27, 2024

Description

Ticket: CP-9266

  • always prompt permission dialog when a website is requesting camera and file download permission
  • custom permission prompt is displayed before the system permission prompt

ava-labs/react-native-webview branch

https://github.com/ava-labs/react-native-webview/tree/cp-9266

Screenshots/Videos

camera permission request

XRecorder_01102024_121836.MP4

file download permission request

XRecorder_01102024_131329.MP4

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@@ -6,6 +6,8 @@ nmHoistingLimits: workspaces

nmSelfReferences: false

checksumBehavior: update
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this to fix the cached package issue in CI.

The remote archive doesn't match the expected checksum

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove it in another pr once the issue above is fixed in ci.

Copy link
Collaborator

@atn4z7 atn4z7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait on merging this until we get an approval from security team

Copy link

@chriselbring-avalabs chriselbring-avalabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Very nice, thank you for the quick turnaround on this!

@ruijialin-avalabs ruijialin-avalabs merged commit f8e2bce into main Oct 2, 2024
3 checks passed
@ruijialin-avalabs ruijialin-avalabs deleted the cp-9266 branch October 2, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants