-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate K2 Alpine into Core Mobile #1846
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atn4z7
requested review from
neven-s,
ruijialin-avalabs and
onghwan
as code owners
October 1, 2024 16:19
atn4z7
commented
Oct 1, 2024
Comment on lines
+4
to
+5
"target": "esnext", | ||
"module": "esnext", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to adjust module and target so that typescript allows the lazy imports
onghwan
reviewed
Oct 1, 2024
"main": "expo/AppEntry.js", | ||
"files": [ | ||
"./src/index.ts" | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we still need expo
, expo-font
, expo-splash-screen
and expo-status-bar
?
onghwan
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ticket: CP-9044
k2-alpine
to control whether to display k2 alpine screens/componentswithK2Alpine
:TODO:
Screenshots/Videos
Screen.Recording.2024-10-01.at.11.08.59.AM.mov
Testing
Go to watchlist screen, toggle the feature flag to see new K2 alpine screen
Checklist
Please check all that apply (if applicable)