Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate K2 Alpine into Core Mobile #1846

Merged
merged 12 commits into from
Oct 2, 2024
Merged

Integrate K2 Alpine into Core Mobile #1846

merged 12 commits into from
Oct 2, 2024

Conversation

atn4z7
Copy link
Collaborator

@atn4z7 atn4z7 commented Oct 1, 2024

Description

Ticket: CP-9044

  • new feature flag k2-alpine to control whether to display k2 alpine screens/components
  • new HoC withK2Alpine :
    • conditionally render either the old or the new version of a component based on K2 ALPINE feature flag.
    • ensure both the old and new components are interchangeable by enforcing that they accept the same props.
    • ensure that both old and new components are lazily loaded via React.lazy.
  • integrate with k2 alpine:
    • add k2 alpine fonts
    • add an example Watchlist screen

TODO:

  • auto-complete/IntelliSense for theme tokens is not working yet since both k2 and k2-alpine use Dripsy. created a ticket to tackle it.

Screenshots/Videos

Screen.Recording.2024-10-01.at.11.08.59.AM.mov

Testing

Go to watchlist screen, toggle the feature flag to see new K2 alpine screen

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

Comment on lines +4 to +5
"target": "esnext",
"module": "esnext",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

had to adjust module and target so that typescript allows the lazy imports

"main": "expo/AppEntry.js",
"files": [
"./src/index.ts"
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need expo, expo-font, expo-splash-screen and expo-status-bar?

@atn4z7 atn4z7 merged commit eebdd70 into main Oct 2, 2024
3 checks passed
@atn4z7 atn4z7 deleted the integrate-k2 branch October 2, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants