Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - Handle pixel6 correctly for bitrise smoke run #1848

Merged
merged 1 commit into from
Oct 1, 2024
Merged

QA - Handle pixel6 correctly for bitrise smoke run #1848

merged 1 commit into from
Oct 1, 2024

Conversation

eunjisong
Copy link
Contributor

Description

  • Pixel6 is only for parameterized tests on regression. I found out pixel6 not correctly handled on smoke run. It should bypass the parameterized tests on smoke run correctly

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong changed the title fix bitrise pixel6 for smoke run QA - Handle bitrise pixel6 correctly for bitrise smoke run Oct 1, 2024
@eunjisong eunjisong marked this pull request as ready for review October 1, 2024 18:16
@eunjisong eunjisong changed the title QA - Handle bitrise pixel6 correctly for bitrise smoke run QA - Handle pixel6 correctly for bitrise smoke run Oct 1, 2024
@eunjisong eunjisong merged commit 0d6ccd4 into main Oct 1, 2024
3 checks passed
@eunjisong eunjisong deleted the qa/fix-bitrise-101 branch October 1, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@atn4z7 atn4z7 Awaiting requested review from atn4z7 atn4z7 is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

@onghwan onghwan Awaiting requested review from onghwan onghwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66