Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - clean up configs and fix tests #1865

Merged
merged 6 commits into from
Oct 2, 2024
Merged

QA - clean up configs and fix tests #1865

merged 6 commits into from
Oct 2, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Oct 2, 2024 •
edited
Loading

Description

  • Fix tests
  • Clean up configs. Most of the test files don't exist and they are not necessary to be added to configs.

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong changed the title fix and bring some tests back for running QA - clean up configs and fix tests Oct 2, 2024
@eunjisong eunjisong marked this pull request as ready for review October 2, 2024 18:23
@eunjisong eunjisong merged commit 973f307 into main Oct 2, 2024
3 checks passed
@eunjisong eunjisong deleted the qa/fix-102 branch October 2, 2024 20:49
@Any2suited66 Any2suited66 restored the qa/fix-102 branch October 14, 2024 16:12
@Any2suited66 Any2suited66 deleted the qa/fix-102 branch October 14, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66