QA - New: Notification setting tests and getting ready for notification service testing #1900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eunjisong
changed the title
eunjisong
commented
Oct 8, 2024
| import portfolioPage from '../../pages/portfolio.page' | ||
| import sendPage from '../../pages/send.page' | ||
|
|
||
| describe('Send Notification', () => { |
There was a problem hiding this comment.
The push notification is broken currently. I added a file and folder as a placeholder and a reminder for future work. I marked the test to be ignored in config files.
eunjisong
requested review from
Any2suited66,
neven-s,
atn4z7,
ruijialin-avalabs and
onghwan
as code owners
Any2suited66
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
verifyPushNotification,tapPushNotification, andverifyNoPushNotificationare added as placeholders for future testing. We can update the methods and remove the ignore test label once the push notification is fixedChecklist
Please check all that apply (if applicable)