Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add camera qr scanner to nftSendStack #1903

Merged
merged 1 commit into from
Oct 9, 2024
Merged

add camera qr scanner to nftSendStack #1903

merged 1 commit into from
Oct 9, 2024

Conversation

Any2suited66
Copy link
Contributor

@Any2suited66 Any2suited66 commented Oct 8, 2024 •
edited by jira bot
Loading

Description

Ticket: CP-7922

  • Please let me know if there is a better way to do this. It's been awhile since i've worked on a developer ticket.
  • Added the QR scanner to the address field on the Send Nft screen.
  • As a user I don't want to have to type out someones address manually each time to send an nft

Screenshots/Videos

qr_scanner_example.mp4

Testing

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

atn4z7
atn4z7 approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@atn4z7 atn4z7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@Any2suited66 Any2suited66 merged commit 93c58cd into main Oct 9, 2024
3 checks passed
@Any2suited66 Any2suited66 deleted the CP-7922 branch October 9, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atn4z7 atn4z7 atn4z7 approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

@onghwan onghwan Awaiting requested review from onghwan onghwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Any2suited66 @atn4z7