Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - small fixes for the smoke test #1961

Merged
merged 1 commit into from
Oct 15, 2024
Merged

QA - small fixes for the smoke test #1961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core-mobile/app/screens/bridge/components/BridgeTransactionItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const BridgeTransactionItem: FC<BridgeTransactionItemProps> = ({

return (
<AvaListItem.Base
testID="activityListItem"
testID="bridgeActivityListItem"
title={pending ? 'Bridging...' : 'Bridge'}
leftComponent={
<View
Expand Down
1 change: 1 addition & 0 deletions packages/core-mobile/e2e/locators/activityTab.loc.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export default {
transaction: 'activity_list__Contract Call',
activityDetail: 'activity_detail__amount',
activityListItem: 'activityListItem',
bridgeActivityListItem: 'bridgeActivityListItem',
activityListItemAmount: 'acitivty_item_amount',
avaxOutgoingTransactionDetail: '-0.0001 AVAX',
avaxIncomingTransactionDetail: '+0.0001 AVAX',
Expand Down
4 changes: 4 additions & 0 deletions packages/core-mobile/e2e/pages/activityTab.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ class ActivityTabPage {
return by.id(activityTab.activityListItemAmount)
}

get bridgeActivityListItem() {
return by.id(activityTab.bridgeActivityListItem)
}

get selectFilterDropdown() {
return by.id(activityTab.currentFilter)
}
Expand Down
5 changes: 2 additions & 3 deletions packages/core-mobile/e2e/pages/popUpModal.page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,11 +160,10 @@ class PopUpModalPage {

async verifyApproveTransactionScreen() {
try {
await actions.waitForElement(this.approveBtn, 5000)
} catch (e) {
await sendPage.tapNextButton()
} catch (e) {
await actions.waitForElement(this.approveBtn, 10000)
}
await actions.waitForElement(this.approveBtn, 5000)
}

async verifyFeeIsLegit(isPXChain = false, estimatedGasFee = 0.009) {
Expand Down
5 changes: 2 additions & 3 deletions packages/core-mobile/e2e/tests/activityTab/activityTab.e2e.smoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import Actions from '../../helpers/actions'
import ActivityTabPage from '../../pages/activityTab.page'
import PortfolioPage from '../../pages/portfolio.page'
import { warmup } from '../../helpers/warmup'
import activityTabPage from '../../pages/activityTab.page'
import accountManagePage from '../../pages/accountManage.page'

describe('Filter transactions on Activity List', () => {
Expand All @@ -28,9 +27,9 @@ describe('Filter transactions on Activity List', () => {
await ActivityTabPage.tapBridgeFilterOption()
await ActivityTabPage.verifySelectedFilter('Bridge')
try {
await ActivityTabPage.verifyExistingRow('Bridge')
await Actions.waitForElement(ActivityTabPage.bridgeActivityListItem)
} catch (error) {
await Actions.waitForElement(activityTabPage.noRecentActivity)
await Actions.waitForElement(ActivityTabPage.noRecentActivity)
}
})

Expand Down
2 changes: 1 addition & 1 deletion packages/core-mobile/e2e/tests/plusIcon/walletConnect/dappIntegrationsCore.e2e.smoke.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ describe('Dapp - Core', () => {
await browserPage.connectTermAndContinue()
await browserPage.connectCore()
await connectToSitePage.selectAccountAndconnect()
})
}, 60000)

it('should verify core.app connected', async () => {
await securityAndPrivacyPage.goToConnectedSites()
Expand Down
Loading