Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA - new: Test StakeCard and StakeDetail screens with data #1974

Merged
merged 2 commits into from
Oct 18, 2024
Merged

QA - new: Test StakeCard and StakeDetail screens with data #1974

merged 2 commits into from
Oct 18, 2024

Conversation

eunjisong
Copy link
Contributor

@eunjisong eunjisong commented Oct 18, 2024 •
edited
Loading

Description

  • Currently, we don't have testing coverage for StakeCard and StakeCardDetail. It's testing both static text and stake card data with title name, staked amount, rewards, and the time.
  • Tested and verified it's passing on both iOS and Android.

Testing

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

eunjisong
eunjisong commented Oct 18, 2024
View reviewed changes
packages/core-mobile/e2e/tests/notification/sendNotification.e2e.ts
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't get notifications on simulator/emulators so I am deleting the test

@eunjisong eunjisong marked this pull request as ready for review October 18, 2024 15:12
@eunjisong eunjisong merged commit fb9b387 into main Oct 18, 2024
4 checks passed
@eunjisong eunjisong deleted the qa/new-1017 branch October 18, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Any2suited66 Any2suited66 Any2suited66 approved these changes

@neven-s neven-s Awaiting requested review from neven-s neven-s is a code owner

@atn4z7 atn4z7 Awaiting requested review from atn4z7 atn4z7 is a code owner

@ruijialin-avalabs ruijialin-avalabs Awaiting requested review from ruijialin-avalabs ruijialin-avalabs is a code owner

@onghwan onghwan Awaiting requested review from onghwan onghwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eunjisong @Any2suited66