Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA - Handle swap failures and other test fixes #2046

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Conversation

eunjisong
Copy link
Contributor

Description

  • sometimes swap fails because of amount is not enough. We'll update the swap amount every time we see amount-related errors.
  • Sometimes core.app connect test fails because core.app is not loading properly on the web side. We'll check the error first and then proceed the test
  • these should handle flakyness
  • Tested on both iOS and Android

Testing

Checklist

Please check all that apply (if applicable)

  • I have performed a self-review of my code
  • I have verified the code works
  • I have added/updated necessary unit tests
  • I have updated the documentation

@eunjisong eunjisong marked this pull request as ready for review November 1, 2024 21:38
@Any2suited66 Any2suited66 merged commit 14a41f2 into main Nov 1, 2024
4 checks passed
@Any2suited66 Any2suited66 deleted the qa/fix-1101 branch November 1, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants