Cleanup accepted logs subscription test #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ceyonur
approved these changes
Jul 13, 2023
joshua-kim
added a commit
that referenced
this pull request
Jul 18, 2023
commit c6c0b1d Author: Dan Laine <daniel.laine@avalabs.org> Date: Tue Jul 18 10:02:30 2023 -0400 Rename sorting method imported from avalanchego (#272) * update avalanchego version * rename sorting method import * update avalanchego dep * fix sorting method name * fix sorting method name for real commit 734c238 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 21:13:39 2023 -0400 Add release notes and bump AvalancheGo dep (#289) commit e024457 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 14:39:58 2023 -0400 Prevent panic for LOG edge cases in callTracer (#285) * cherry-pick tracer log edge case handling * Update goja --------- Co-authored-by: jwasinger <j-wasinger@hotmail.com> commit 1855d7e Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Jul 17 11:39:11 2023 -0700 Whitespace and nits (#287) * Whitespace and nits * add cpfg fix commit 72df753 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 14:37:11 2023 -0400 Prestate lookup account storage (#286) * Add lookupAccount in lookupStorage * fix tracer regression * Move tracer test to new directory --------- Co-authored-by: morrisettjohn <morrisettjohn@gmail.com> commit 261d2ad Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Fri Jul 14 11:17:33 2023 -0400 Cleanup accepted logs subscription test (#283) commit a025ecc Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Jul 10 11:50:09 2023 -0700 Use go1.19 in CI for consistency with avalanchego (#278) commit 419b262 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Fri Jul 7 13:07:54 2023 -0700 Fix goroutine leaks in core/ tests (#273) commit fbd9dad Author: Dan Laine <daniel.laine@avalabs.org> Date: Wed Jun 28 14:22:38 2023 -0400 Use avalanchego's sorting methods (#260) * use avalanchgo sorting functions * add tests for Less * import ordering * import ordering * Use `slices` methods instead of `sort` methods (#261) * use slices.Sort instead of sort.Slice * import ordering * add test case commit 3f0df72 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jun 26 23:10:03 2023 -0400 Bump to v0.12.4 (#271) commit 6c9d2c3 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Thu Jun 22 00:42:44 2023 -0400 Fix collect unflattened logs (#270) * Handle empty logs edge case in collectUnflattenedLogs * Add unit test to check log handling for block with atomic tx and no eth transactions * Fix race and add nil check commit c08a7c1 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Tue Jun 20 15:05:03 2023 -0700 Restrict ClearPrefix by key size (#265) commit 0d02ea7 Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Jun 15 11:07:31 2023 -0400 export CalculateDynamicFee (#259) commit 0eb8685 Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Jun 15 10:48:26 2023 -0400 update golangci-lint-action (#263)
joshua-kim
added a commit
to joshua-kim/coreth
that referenced
this pull request
Jul 27, 2023
commit 8ef933f Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Tue Jul 25 07:12:10 2023 -0700 Takes geth changes v1.11.14 -> v1.12.0 (ava-labs#277) * trie/ * remove rej file * metrics/ * accounts/ * internal * rpc/ * core/rawdb * go.mod * core/state * eth/... * core/vm core/types/ ethdb * core/txpool * left out * additional core/ * should pass tests * nits * remove .rej file * newTestBlockChain TODO * Pr comments * remove ExcessDataGas * Add ExcessDataGas with verification * Add verification in plugin/evm commit 8a8a220 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Fri Jul 21 11:36:26 2023 -0400 Bump coreth to v0.12.5 and bump avalanchego dep to v1.10.5 (ava-labs#291) commit 1da5b37 Author: Anusha <63559942+anusha-ctrl@users.noreply.github.com> Date: Thu Jul 20 12:32:22 2023 -0700 remove (ava-labs#290) commit c6c0b1d Author: Dan Laine <daniel.laine@avalabs.org> Date: Tue Jul 18 10:02:30 2023 -0400 Rename sorting method imported from avalanchego (ava-labs#272) * update avalanchego version * rename sorting method import * update avalanchego dep * fix sorting method name * fix sorting method name for real commit 734c238 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 21:13:39 2023 -0400 Add release notes and bump AvalancheGo dep (ava-labs#289) commit e024457 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 14:39:58 2023 -0400 Prevent panic for LOG edge cases in callTracer (ava-labs#285) * cherry-pick tracer log edge case handling * Update goja --------- Co-authored-by: jwasinger <j-wasinger@hotmail.com> commit 1855d7e Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Jul 17 11:39:11 2023 -0700 Whitespace and nits (ava-labs#287) * Whitespace and nits * add cpfg fix commit 72df753 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jul 17 14:37:11 2023 -0400 Prestate lookup account storage (ava-labs#286) * Add lookupAccount in lookupStorage * fix tracer regression * Move tracer test to new directory --------- Co-authored-by: morrisettjohn <morrisettjohn@gmail.com> commit 261d2ad Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Fri Jul 14 11:17:33 2023 -0400 Cleanup accepted logs subscription test (ava-labs#283) commit a025ecc Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Mon Jul 10 11:50:09 2023 -0700 Use go1.19 in CI for consistency with avalanchego (ava-labs#278) commit 419b262 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Fri Jul 7 13:07:54 2023 -0700 Fix goroutine leaks in core/ tests (ava-labs#273) commit fbd9dad Author: Dan Laine <daniel.laine@avalabs.org> Date: Wed Jun 28 14:22:38 2023 -0400 Use avalanchego's sorting methods (ava-labs#260) * use avalanchgo sorting functions * add tests for Less * import ordering * import ordering * Use `slices` methods instead of `sort` methods (ava-labs#261) * use slices.Sort instead of sort.Slice * import ordering * add test case commit 3f0df72 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Mon Jun 26 23:10:03 2023 -0400 Bump to v0.12.4 (ava-labs#271) commit 6c9d2c3 Author: aaronbuchwald <aaron.buchwald56@gmail.com> Date: Thu Jun 22 00:42:44 2023 -0400 Fix collect unflattened logs (ava-labs#270) * Handle empty logs edge case in collectUnflattenedLogs * Add unit test to check log handling for block with atomic tx and no eth transactions * Fix race and add nil check commit c08a7c1 Author: Darioush Jalali <darioush.jalali@avalabs.org> Date: Tue Jun 20 15:05:03 2023 -0700 Restrict ClearPrefix by key size (ava-labs#265) commit 0d02ea7 Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Jun 15 11:07:31 2023 -0400 export CalculateDynamicFee (ava-labs#259) commit 0eb8685 Author: Dan Laine <daniel.laine@avalabs.org> Date: Thu Jun 15 10:48:26 2023 -0400 update golangci-lint-action (ava-labs#263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
This PR cleans up the existing accepted log subscription unit test by renaming it and moving variables only relevant to this test inside of the relevant test.
How this works
Just cleanup
How this was tested
Run modified test locally + CI