Refactor p2p unit tests #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
commented
Dec 12, 2023
joshua-kim
commented
Dec 12, 2023
joshua-kim
force-pushed
the
sdk-refactor
branch
from
d1e2e46 to
b443040
Compare
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
joshua-kim
force-pushed
the
sdk-refactor
branch
from
b443040 to
bb628f9
Compare
joshua-kim
requested review from
aaronbuchwald,
darioush and
ceyonur
as code owners
darioush
previously approved these changes
Dec 12, 2023
There was a problem hiding this comment.
I think this is a good improvement so I am approving this PR.
I think we should find a coherent strategy for initializing & wiring objects during testing. May be worthwhile to look into golang best practices or agree on some standards for further improvement.
joshua-kim
commented
Dec 12, 2023
commit 056800c Author: Joshua Kim <20001595+joshua-kim@users.noreply.github.com> Date: Wed Dec 13 00:28:59 2023 -0500 Update to new SDK API (#421) commit 42db2c2 Author: Ceyhun Onur <ceyhun.onur@avalabs.org> Date: Tue Dec 12 19:05:37 2023 +0300 show strings in pointers (#414) Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
darioush
approved these changes
Dec 13, 2023
Co-authored-by: Darioush Jalali <darioush.jalali@avalabs.org> Signed-off-by: Joshua Kim <20001595+joshua-kim@users.noreply.github.com>
StephenButtolph
approved these changes
Dec 13, 2023
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* Simplify e2e tests * Add TODOs * WIP * Replace GetSubnetIDF * Bump avalanchego to v1.9.6-rc.0 * Working on tests * Light client mode to unlock dynamic state sync * revert version to pass ci (?) * fix simulator go.mod * Set env variable using os setenv * Needed renames to run all solidity precompile tests * Cleanup * E2E test GH Action * Remove simualtor from GH Actions * Re-add simulator to GH Actions * nits * Modify run script to support running a network and running simulator * Fix GH Actions file * Bump avalanchego to v1.9.6-rc.2 * go mod tidy * Fix run script * Reduce ctx timeout for starting new subnet to 15s * Set data dir from github action * Update run script * Create separate load test for ginkgo * Refactor scripts * Fix up env variables in run single node script * WIP * Add install_cli.sh script * Create 1 script to start a non-staking network of nodes in a subshell * Fix run script to run 5 node non-staking network and add simple load script * Fix load test * go mod update to ago v1.9.7 * Fix allowed geth imports for simulator * Populate constants to fix blst warning * load constants in run ginkgo * Update run simulator name check * Update data dir * Add plugin dir env variable * Update github action and env var used in install avago script * Filter out both precompile and load test from unit test script * Add comment about skipping load test in unit test script * Fix lint geth allowed pkgs * Address nits * Remove unused DATA_DIRs var from run script * Add TODO to update run script to allow running N nodes instead of just one * Update READMEs * Break down simulator * Cleanup * Update cmd/simulator/README.md * Update cmd/simulator/README.md * Update cmd/simulator/README.md * Update contract-examples/README.md * Address review comments * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
the P2P unit tests are confusing + spin up goroutines, this PR refactors all of them to be simpler
How this works
See above
How this was tested
UTs