remove no-op handler #436
Merged
remove no-op handler #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-kim
approved these changes
Dec 27, 2023
darioush
approved these changes
Dec 27, 2023
darioush
pushed a commit
that referenced
this pull request
Apr 25, 2024
* sync changes from coreth-0.11.6 * remove diff patch * revert format changes * nits (#441)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
Embedding the no-op handler could result into unexpected behavior in case interface changes and no-op handler implementation changes. IMO it's better to depend on the interface type check and introduce breaking change rather than using a no-op implementation
How this works
Removes embedded no-op handler and implements interface functions.
How this was tested
UTs should cover this.