chore(core/types): Body RLP codec hooks (5)
#760
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
2be5a7b to
87f5043
Compare
qdm12
changed the title
Body libevm RLP codec hooks
qdm12
commented
Jan 21, 2025
2 tasks
qdm12
changed the base branch from
libevm-upstream-types
to
qdm12/core/types/header-copy-hooks
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
da83d82 to
58f1171
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
9978144 to
7027a42
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
2 times, most recently
from
53eb228 to
d65a0d2
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
2 times, most recently
from
3593f92 to
1daa313
Compare
qdm12
changed the title
Body libevm RLP codec hooksBody RLP codec hooks (5)
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
3 times, most recently
from
da70431 to
3ff7dea
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
d65a0d2 to
787b67d
Compare
qdm12
force-pushed
the
qdm12/core/types/header-copy-hooks
branch
from
3ff7dea to
783edc9
Compare
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
787b67d to
9e52047
Compare
qdm12
commented
Feb 12, 2025
| @@ -152,7 +143,15 @@ func (b *Block) EncodeRLP(w io.Writer) error { | |||
| // Body returns the non-header content of the block. | |||
| // Note the returned data is not an independent copy. | |||
| func (b *Block) Body() *Body { | |||
| return &Body{b.transactions, b.uncles, b.version, b.extdata} | |||
| body := &Body{ | |||
qdm12
force-pushed
the
qdm12/core/types/body-libevm
branch
from
bb94d07 to
3c3ee20
Compare
qdm12
commented
Feb 12, 2025
| &body.Transactions, | ||
| &body.Uncles, | ||
| &b.Version, | ||
| &b.ExtData, |
There was a problem hiding this comment.
Maybe a dumb remark, but note this doesn't use rlp.Nillable, I believe this is what we want correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
Note: this branch is independent but it's based on #759 because the next PR #750 depend on both this PR and #759
How this was tested
Need to be documented?
Need to update RELEASES.md?