Reflect Marshaler #1592
Open
Reflect Marshaler #1592
+270
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
containerman17
requested review from
aaronbuchwald and
joshua-kim
as code owners
ARR4N
reviewed
Sep 27, 2024
abi/dynamic/reflect_marshal.go
Outdated
| // Find the type in the ABI | ||
| abiType := findABIType(inputAbi, abiTypeName) | ||
| if abiType == nil { | ||
| // If not found, fallback to interface{} |
There was a problem hiding this comment.
Why? Please elaborate in the comment.
There was a problem hiding this comment.
It makes much more sense to return errors here instead of just an empty value, I agree. Yeah, that was a dumb thing to do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A single CLI binary to manage all the HyperSDK VMs sounds great. However, the current ABI implementation requires regenerating structs with data types for each VM. This PR changes that by generating structs dynamically using reflection.
This package should NOT be used within VMs, only in CLI applications. I'm happy to rename it if you have better ideas.
P.S. I've also added
0xto addresses to follow the recent changes.P.S. Please take some extra time during the code review or suggest additional test cases. The code is short but does quite a bit. It is well-tested using the existing
abipackage specs, but I wouldn’t call myself an expert with Go’sreflectpackage.