Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support procedural test style for VM-defined workloads #1667
support procedural test style for VM-defined workloads #1667
Changes from 2 commits
6f2fc50
1833c3f
a4f51a1
8e22542
fe528f5
baf90fd
ee7974c
0b935bb
83afa8d
2523292
1716ecf
b681a95
9fcc4dc
62048d7
3f7f35c
bb6ca7b
b27c3e7
c55e886
53d05e2
848a8b9
32b6cff
69625eb
f06bcf8
834bf53
128d5fc
93541c0
c4621d6
bb12aa7
473a08d
66d5493
4c55dc3
83231c7
4bc7424
f087929
23f5b79
782f4b2
920c45a
e5bb823
5471cac
2e7261f
4021021
a346111
3b5d436
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm concerned this test doesn't add any real value to a hypersdk VM developer. If anything, it adds less value than the current workload tests because the user doesn't have fine grained controls of what a "confirmed" transaction is. In the workload tests, at least devs can define their custom confirmation logic. In these e2e tests all a user gets back is whether or not the transaction was found in the block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in these custom e2e tests, we only use the
workloadfactory
for this one method. This means if the user wants to only create custom e2e tests they need to also define theworkloadfactory
interface which is quite confusing 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe its worth adding some of the further work you mentioned to this PR. If the
GenesisKeys
are added to the test network then we wouldn't need to couple theWorkloadFactory
hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have a const
txCheckInterval
. I think it makes sense to either pass the const in here or remove the const completely and pass in a value from the test.Check failure on line 39 in tests/e2e/e2e.go
GitHub Actions / hypersdk-lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the const i mentioned earlier
Check failure on line 29 in tests/e2e/network.go
GitHub Actions / hypersdk-lint
Check failure on line 50 in tests/e2e/network.go
GitHub Actions / hypersdk-lint
Check failure on line 50 in tests/e2e/network.go
GitHub Actions / hypersdk-lint
Check failure on line 50 in tests/e2e/network.go
GitHub Actions / hypersdk-lint
Check failure on line 50 in tests/e2e/network.go
GitHub Actions / hypersdk-lint
Check failure on line 68 in tests/e2e/network.go
GitHub Actions / hypersdk-lint