Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MorpheusVM Tutorial #1706

Merged
merged 22 commits into from
Nov 8, 2024
Merged

Update MorpheusVM Tutorial #1706

merged 22 commits into from
Nov 8, 2024

Conversation

RodrigoVillar
Copy link
Contributor

@RodrigoVillar RodrigoVillar commented Oct 31, 2024 •
edited
Loading

This PR updates the MorpheusVM tutorial to reflect the latest changes.

In addition, this PR updates the tutorial to use procedural integration tests and the HyperSDK CLI

@RodrigoVillar RodrigoVillar added the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 4, 2024
@RodrigoVillar
Copy link
Contributor Author

Note: wait for hypersdk-cli package to be updated to include the balance command. Once the command is part of the CLI, then we can merge to main.

@RodrigoVillar RodrigoVillar marked this pull request as ready for review November 4, 2024 21:42
@RodrigoVillar RodrigoVillar removed the DO NOT MERGE This PR is not meant to be merged in its current state label Nov 4, 2024
@RodrigoVillar
Copy link
Contributor Author

Note: wait for hypersdk-cli package to be updated to include the balance command. Once the command is part of the CLI, then we can merge to main.

Updated CLI version used in doc; you can now use the balance command

aaronbuchwald
aaronbuchwald previously approved these changes Nov 7, 2024
View reviewed changes
docs/tutorials/morpheusvm/3_testing.md Outdated
the following:

```go
timeoutCtx, timeoutCtxFnc := context.WithDeadline(context.Background(), time.Now().Add(2*time.Second))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update to use 30s?

docs/tutorials/morpheusvm/3_testing.md Outdated

We now move onto our procedural tests.

## Implementing our Procedural Tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rename from procedural (term used to differentiate from the old gross generator style) to just calling them tests?

I think using the term procedural will just confuse people.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about the following syntax:

  • "tests": refers to all tests we go over
  • "workload tests": self explanatory
  • "integration tests": the procedural tests themselves

This way, there's a clear difference between the two types of tests we're implementing

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "workload tests" to define the tests that we run against both integration and e2e environments?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aaronbuchwald aaronbuchwald merged commit a49321f into main Nov 8, 2024
17 checks passed
@aaronbuchwald aaronbuchwald deleted the morpheusvm-tutorial-update branch November 8, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronbuchwald aaronbuchwald aaronbuchwald approved these changes

@joshua-kim joshua-kim Awaiting requested review from joshua-kim joshua-kim is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RodrigoVillar @aaronbuchwald