Rename emap interface method names #1806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ?
As part of having the shared
validitywindow
implementation being used within thedsmr
, the entries that would be contained would be better off implementing the same interface.The dsmr's interface ( i.e.
Tx
) already usingGetID()
andGetExpiry()
, which seems to be "better" compared to theemap.Item
'sID()
andExpiry()
as there would clash with member names.This PR is a followup on #1782, and part of Generalize expiry based de-duplication