avoid type assertion on Action/Auth in switchs #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| switch action := tx.Action.(type) { //nolint:gocritic | ||
| case *actions.Transfer: | ||
| switch tx.Action.GetTypeID() { //nolint:gocritic | ||
| case (&actions.Transfer{}).GetTypeID(): |
There was a problem hiding this comment.
Ah, I was thinking you just would do:
case TransferTypeID:
There was a problem hiding this comment.
I agree the way it is now (with your current change) is way more confusing/less clean
There was a problem hiding this comment.
I thought about doing it but it makes potentially use a declared ID not used by any Type.
The both were possible.
| case *actions.Transfer: | ||
| switch tx.Action.GetTypeID() { //nolint:gocritic | ||
| case (&actions.Transfer{}).GetTypeID(): | ||
| action := tx.Action.(*actions.Transfer) |
There was a problem hiding this comment.
Ah, I didn't think about the need to do this...probably better to just leave for now.
There was a problem hiding this comment.
We can close this PR and disregard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@patrick-ogrady I am not a big fan of switching from type assertion to
GetTypeID()usage in switch statement.