[crypto/ed25519] ed25519 Concurrent Batch Verification + ZIP-215 Enforcement #338
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #337
TL;DR: single verification cost drops from 45000 ns to 27000 ns when using the new library (-40%) and 45000 ns to 8904 ns (-80%) when using batch verify.
Results:
Results on single core (~same -> can still parallelize):
Before(~100ms/10k txs):
After (~45ms/10k txs):
Notably, there is no wait on signatures anymore in Verify.
TODO
Periodically perform batch verification of txs submitted over RPC/gossip:[crypto] Run Batch Verification on Incoming Gossip #345WaitSignatures
time before/after imagesIntroduce generic cryptography structs: [morpheusvm/tokenvm/indexvm] Change theauth
on one of these to better showcase how to provide your own crypto #267